Fixed [severe] inspection performance issue

Author: retailcoder

RetailCoder.VBE/Inspections/InspectionNames.Designer.cs

@@ -142,7 +142,7 @@
     <value>Instruction contains multiple declarations</value>
   </data>
   <data name="NonReturningFunction_" xml:space="preserve">
-    <value>Function '{0}' returns no value</value>
+    <value>Return value for member '{0}' is never assigned</value>
   </data>
   <data name="ObsoleteCall" xml:space="preserve">
     <value>Use of obsolete Call statement</value>

RetailCoder.VBE/Inspections/InspectionNames.resx

@@ -36,7 +36,8 @@ public ParameterCanBeByValInspection()
         public IEnumerable<CodeInspectionResultBase> GetInspectionResults(VBProjectParseResult parseResult)
         {
             var interfaceMembers = parseResult.Declarations.FindInterfaceMembers()
-                .Concat(parseResult.Declarations.FindInterfaceImplementationMembers());
+                .Concat(parseResult.Declarations.FindInterfaceImplementationMembers())
+                .ToList();
 
             var issues = parseResult.Declarations.Items.Where(declaration =>
                 declaration.DeclarationType == DeclarationType.Parameter

RetailCoder.VBE/Inspections/ParameterCanBeByValInspection.cs

@@ -75,7 +75,8 @@ public IEnumerable<Declaration> FindInterfaceMembers()
                 .ToList();
 
             _interfaceMembers = _declarations.Where(item => ProcedureTypes.Contains(item.DeclarationType)
-                                                            && interfaces.Any(i => item.ParentScope.StartsWith(i)));
+                                                            && interfaces.Any(i => item.ParentScope.StartsWith(i)))
+                                                            .ToList();
             return _interfaceMembers;
         }
 
@@ -93,7 +94,8 @@ public IEnumerable<Declaration> FindInterfaceImplementationMembers()
 
             var members = FindInterfaceMembers();
             _interfaceImplementationMembers = _declarations.Where(item => ProcedureTypes.Contains(item.DeclarationType)
-                && members.Select(m => m.ComponentName + '_' + m.IdentifierName).Contains(item.IdentifierName));
+                && members.Select(m => m.ComponentName + '_' + m.IdentifierName).Contains(item.IdentifierName))
+                .ToList();
 
             return _interfaceImplementationMembers;
         }

Rubberduck.Parsing/Symbols/Declarations.cs

@@ -19,6 +19,11 @@ Project("{6141683F-8A12-4E36-9623-2EB02B2C2303}") = "Rubberduck.Setup32", "Setup
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Rubberduck.Parsing", "Rubberduck.Parsing\Rubberduck.Parsing.csproj", "{A4A618E1-CBCA-435F-9C6C-5181E030ADFC}"
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{07952BD8-646C-4494-965C-E80F3CDE3485}"
+	ProjectSection(SolutionItems) = preProject
+		Performance1.psess = Performance1.psess
+	EndProjectSection
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		CD_ROM|Any CPU = CD_ROM|Any CPU
@@ -254,4 +259,7 @@ Global
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
 	EndGlobalSection
+	GlobalSection(Performance) = preSolution
+		HasPerformanceSessions = true
+	EndGlobalSection
 EndGlobal