Fix reorder params with parens around caller

Author: Hosch250

RetailCoder.VBE/Refactorings/ReorderParameters/ReorderParametersRefactoring.cs

@@ -112,6 +112,16 @@ private void AdjustReferences(IEnumerable<IdentifierReference> references)
                 {
                     argumentList = CallStatement.GetArgumentList(callStmt);
                 }
+                
+                if (argumentList == null)
+                {
+                    var indexExpression = ParserRuleContextHelper.GetParent<VBAParser.IndexExprContext>(reference.Context);
+                    if (indexExpression != null)
+                    {
+                        argumentList = ParserRuleContextHelper.GetChild<VBAParser.ArgumentListContext>(indexExpression);
+                    }
+                }
+
                 if (argumentList == null) { continue; }
                 RewriteCall(argumentList, module);
             }

RubberduckTests/Refactoring/ReorderParametersTests.cs

@@ -352,6 +352,67 @@ End Sub
             Assert.AreEqual(expectedCode, module.Lines());
         }
 
+        [TestMethod]
+        public void RemoveParametersRefactoring_ClientReferencesAreUpdated_ParensAroundCall()
+        {
+            //Input
+            const string inputCode =
+@"Private Sub bar()
+    Dim x As Integer
+    Dim y As Integer
+    y = foo(x, 42)
+    Debug.Print y, x
+End Sub
+
+Private Function foo(ByRef a As Integer, ByVal b As Integer) As Integer
+    a = b
+    foo = a + b
+End Function";
+            var selection = new Selection(8, 20, 8, 20);
+
+            //Expectation
+            const string expectedCode =
+@"Private Sub bar()
+    Dim x As Integer
+    Dim y As Integer
+    y = foo(42, x)
+    Debug.Print y, x
+End Sub
+
+Private Function foo(ByVal b As Integer, ByRef a As Integer) As Integer
+    a = b
+    foo = a + b
+End Function";
+
+            //Arrange
+            var builder = new MockVbeBuilder();
+            VBComponent component;
+            var vbe = builder.BuildFromSingleStandardModule(inputCode, out component, selection);
+            var project = vbe.Object.VBProjects.Item(0);
+            var module = project.VBComponents.Item(0).CodeModule;
+            var mockHost = new Mock<IHostApplication>();
+            mockHost.SetupAllProperties();
+            var parser = MockParser.Create(vbe.Object, new RubberduckParserState(new Mock<ISinks>().Object));
+
+            parser.Parse(new CancellationTokenSource());
+            if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
+
+            var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
+
+            //set up model
+            var model = new ReorderParametersModel(parser.State, qualifiedSelection, null);
+            model.Parameters.Reverse();
+
+            var factory = SetupFactory(model);
+
+            //act
+            var refactoring = new ReorderParametersRefactoring(vbe.Object, factory.Object, null);
+            refactoring.Refactor(qualifiedSelection);
+
+            //assert
+            Assert.AreEqual(expectedCode, module.Lines());
+        }
+
         [TestMethod]
         public void ReorderParametersRefactoring_ReorderNamedParams()
         {