Skip to content

Commit 3f29abd

Browse files
Vogel612Vogel612
authored
Merge pull request #3835 from IvenBach/Issue3829
Freeze column header for vertical scrolling, fixes #3829
2 parents 7a599fe + eb9f700 commit 3f29abd

File tree

2 files changed

+32
-48
lines changed

2 files changed

+32
-48
lines changed

‎Rubberduck.Core/UI/UnitTesting/TestExplorerControl.xaml

Lines changed: 32 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -599,48 +599,45 @@
599599
</ProgressBar>
600600

601601
<Border Grid.Row="2" Padding="2">
602-
<ScrollViewer PreviewMouseWheel="ScrollViewer_MouseWheel"
603-
VerticalScrollBarVisibility="Auto">
604-
<Grid>
605-
<controls:GroupingGrid ItemsSource="{Binding Source={StaticResource ResultsByOutcome}}"
602+
<Grid>
603+
<controls:GroupingGrid ItemsSource="{Binding Source={StaticResource ResultsByOutcome}}"
606604
SelectedItem="{Binding SelectedTest}"
607605
ShowGroupingItemCount="True"
608606
Visibility="{Binding IsChecked, ElementName=GroupByOutcome, Converter={StaticResource BoolToVisibility}}"
609607
Margin="-1,0,1,0">
610-
<DataGrid.Columns>
611-
<DataGridTemplateColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_Outcome}">
612-
<DataGridTemplateColumn.CellTemplate>
613-
<DataTemplate DataType="unitTesting:TestMethod">
614-
<Image Source="{Binding Result.Outcome, Converter={StaticResource OutcomeIconConverter}}" Height="16" />
615-
</DataTemplate>
616-
</DataGridTemplateColumn.CellTemplate>
617-
</DataGridTemplateColumn>
618-
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_QualifiedModuleName}" Binding="{Binding Declaration.QualifiedName.QualifiedModuleName}" />
619-
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_MethodName}" Binding="{Binding Declaration.IdentifierName}" />
620-
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_Message}" Binding="{Binding Result.Output}" Width="*" />
621-
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_Duration}" Binding="{Binding Result.Duration, StringFormat={}{0}ms}" />
622-
</DataGrid.Columns>
623-
</controls:GroupingGrid>
624-
<controls:GroupingGrid ItemsSource="{Binding Source={StaticResource ResultsByModule}}"
608+
<DataGrid.Columns>
609+
<DataGridTemplateColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_Outcome}">
610+
<DataGridTemplateColumn.CellTemplate>
611+
<DataTemplate DataType="unitTesting:TestMethod">
612+
<Image Source="{Binding Result.Outcome, Converter={StaticResource OutcomeIconConverter}}" Height="16" />
613+
</DataTemplate>
614+
</DataGridTemplateColumn.CellTemplate>
615+
</DataGridTemplateColumn>
616+
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_QualifiedModuleName}" Binding="{Binding Declaration.QualifiedName.QualifiedModuleName}" />
617+
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_MethodName}" Binding="{Binding Declaration.IdentifierName}" />
618+
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_Message}" Binding="{Binding Result.Output}" Width="*" />
619+
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_Duration}" Binding="{Binding Result.Duration, StringFormat={}{0}ms}" />
620+
</DataGrid.Columns>
621+
</controls:GroupingGrid>
622+
<controls:GroupingGrid ItemsSource="{Binding Source={StaticResource ResultsByModule}}"
625623
SelectedItem="{Binding SelectedTest}"
626624
ShowGroupingItemCount="True"
627625
Visibility="{Binding IsChecked, ElementName=GroupByLocation, Converter={StaticResource BoolToVisibility}}">
628-
<DataGrid.Columns>
629-
<DataGridTemplateColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_Outcome}">
630-
<DataGridTemplateColumn.CellTemplate>
631-
<DataTemplate DataType="unitTesting:TestMethod">
632-
<Image Source="{Binding Result.Outcome, Converter={StaticResource OutcomeIconConverter}}" Height="16" />
633-
</DataTemplate>
634-
</DataGridTemplateColumn.CellTemplate>
635-
</DataGridTemplateColumn>
636-
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_QualifiedModuleName}" Binding="{Binding Declaration.QualifiedName.QualifiedModuleName}" />
637-
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_MethodName}" Binding="{Binding Declaration.QualifiedName.MemberName}" />
638-
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_Message}" Binding="{Binding Result.Output}" Width="*" />
639-
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_Duration}" Binding="{Binding Result.Duration, StringFormat={}{0}ms}" />
640-
</DataGrid.Columns>
641-
</controls:GroupingGrid>
642-
</Grid>
643-
</ScrollViewer>
626+
<DataGrid.Columns>
627+
<DataGridTemplateColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_Outcome}">
628+
<DataGridTemplateColumn.CellTemplate>
629+
<DataTemplate DataType="unitTesting:TestMethod">
630+
<Image Source="{Binding Result.Outcome, Converter={StaticResource OutcomeIconConverter}}" Height="16" />
631+
</DataTemplate>
632+
</DataGridTemplateColumn.CellTemplate>
633+
</DataGridTemplateColumn>
634+
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_QualifiedModuleName}" Binding="{Binding Declaration.QualifiedName.QualifiedModuleName}" />
635+
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_MethodName}" Binding="{Binding Declaration.QualifiedName.MemberName}" />
636+
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_Message}" Binding="{Binding Result.Output}" Width="*" />
637+
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=TestExplorer_Duration}" Binding="{Binding Result.Duration, StringFormat={}{0}ms}" />
638+
</DataGrid.Columns>
639+
</controls:GroupingGrid>
640+
</Grid>
644641
</Border>
645642
<controls:BusyIndicator Grid.Row="2" Width="120" Height="120" Visibility="{Binding Model.IsBusy, Converter={StaticResource BoolToVisibility}}" />
646643
</Grid>

‎Rubberduck.Core/UI/UnitTesting/TestExplorerControl.xaml.cs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -54,18 +54,5 @@ public void Dispose()
5454

5555
_isDisposed = true;
5656
}
57-
58-
private void ScrollViewer_MouseWheel(object sender, MouseWheelEventArgs e)
59-
{
60-
if (e.Delta > 0)
61-
{
62-
((ScrollViewer)sender).LineUp();
63-
}
64-
else
65-
{
66-
((ScrollViewer)sender).LineDown();
67-
}
68-
69-
}
7057
}
7158
}

0 commit comments

Comments
 (0)