Address PR comments

Author: BZngr

Rubberduck.CodeAnalysis/Inspections/Concrete/ImplicitByRefModifierInspection.cs

@@ -67,7 +67,7 @@ protected override bool IsResultDeclaration(Declaration declaration, Declaration
                     && !finder.FindEventHandlers().Contains(enclosingMethod);
         }
 
-        private bool IsPropertyMutatorRHSParameter(ModuleBodyElementDeclaration enclosingMethod, ParameterDeclaration implicitByRefParameter)
+        private static bool IsPropertyMutatorRHSParameter(ModuleBodyElementDeclaration enclosingMethod, ParameterDeclaration implicitByRefParameter)
         {
             return (enclosingMethod.DeclarationType.HasFlag(DeclarationType.PropertyLet)
                     || enclosingMethod.DeclarationType.HasFlag(DeclarationType.PropertySet)) 

Rubberduck.CodeAnalysis/Inspections/Concrete/MisleadingByRefParameterInspection.cs

@@ -49,24 +49,20 @@ public MisleadingByRefParameterInspection(IDeclarationFinderProvider declaration
 
         protected override bool IsResultDeclaration(Declaration declaration, DeclarationFinder finder)
         {
-            if ((declaration is ParameterDeclaration parameter)  
+            return declaration is ParameterDeclaration parameter
+                && !(parameter.AsTypeDeclaration?.DeclarationType.HasFlag(DeclarationType.UserDefinedType) ?? false)
                 && parameter.ParentDeclaration is ModuleBodyElementDeclaration enclosingMethod
                 && (enclosingMethod.DeclarationType.HasFlag(DeclarationType.PropertyLet)
                     || enclosingMethod.DeclarationType.HasFlag(DeclarationType.PropertySet))
                 && enclosingMethod.Parameters.Last() == parameter
-                && !(parameter.AsTypeDeclaration?.DeclarationType.HasFlag(DeclarationType.UserDefinedType) ?? false))
-            {
-                return parameter.IsByRef && !parameter.IsImplicitByRef;
-            }
-
-            return false;
+                && parameter.IsByRef && !parameter.IsImplicitByRef;
         }
 
         protected override string ResultDescription(Declaration declaration)
         {
             return string.Format(
                 InspectionResults.MisleadingByRefParameterInspection,
-                declaration.IdentifierName);
+                declaration.IdentifierName, declaration.ParentDeclaration.QualifiedName.MemberName);
         }
     }
 }

Rubberduck.Resources/Inspections/InspectionInfo.Designer.cs

@@ -443,6 +443,6 @@ If the parameter can be null, ignore this inspection result; passing a null valu
     <value>An annotation has more arguments than allowed; superfluous arguments are ignored.</value>
   </data>
   <data name="MisleadingByRefParameterInspection" xml:space="preserve">
-    <value>The last parameter (the 'Value' parameter) of property mutators are always passed by value.  This is true regardless of the presence or absence of a ByVal modifier.  Exception: UserDefinedType parameters must always be passed by reference in all cases.</value>
+    <value>The last parameter (the 'Value' parameter) of property mutators are always passed ByVal. This is true regardless of the presence or absence of a ByRef or ByVal modifier. Exception: A UserDefinedType must always be passed ByRef even when it is the last parameter of a property mutator.</value>
   </data>
 </root>

Rubberduck.Resources/Inspections/InspectionInfo.resx

@@ -443,6 +443,6 @@
     <value>Superfluous annotation arguments</value>
   </data>
   <data name="MisleadingByRefParameterInspection" xml:space="preserve">
-    <value>ByRef is a misleading modifier because the parameter will be passed ByVal.</value>
+    <value>Misleading ByRef parameter modifier</value>
   </data>
 </root>

Rubberduck.Resources/Inspections/InspectionNames.Designer.cs

@@ -514,7 +514,7 @@ In memoriam, 1972-2018</value>
     <comment>{0} annotation name</comment>
   </data>
   <data name="MisleadingByRefParameterInspection" xml:space="preserve">
-    <value>Misleading ByRef modifier used for Parameter '{0}'.</value>
-    <comment>{0} Parameter name</comment>
+    <value>Misleading ByRef modifier used for parameter '{0}' ({1}).</value>
+    <comment>{0} Parameter, {1} Member</comment>
   </data>
 </root>