Log exceptions

Hosch250 · Hosch250 · commit 3b7a8df84e99 · 2016-06-28T12:20:38.000-05:00
diff --git a/RetailCoder.VBE/Root/FatalExceptionInterceptor.cs b/RetailCoder.VBE/Root/FatalExceptionInterceptor.cs
@@ -0,0 +1,20 @@
+﻿using System;
+using Ninject.Extensions.Interception;
+using NLog;
+
+namespace Rubberduck.Root
+{
+    /// <summary>
+    /// An interceptor that logs an unhandled exception.
+    /// </summary>
+    public class FatalExceptionInterceptor : InterceptorBase
+    {
+        private readonly ILogger _logger = LogManager.GetCurrentClassLogger();
+
+        protected override void OnError(IInvocation invocation, Exception exception)
+        {
+            _logger.Fatal(exception);
+            throw new InterceptedException(exception);
+        }
+    }
+}
diff --git a/RetailCoder.VBE/Root/RubberduckModule.cs b/RetailCoder.VBE/Root/RubberduckModule.cs
@@ -170,7 +170,7 @@ private void ApplyDefaultInterfacesConvention(IEnumerable<Assembly> assemblies)
                 // inspections & factories have their own binding rules
                 .Where(type => !type.Name.EndsWith("Factory") && !type.Name.EndsWith("ConfigProvider") && !type.GetInterfaces().Contains(typeof(IInspection)))
                 .BindDefaultInterface()
-                .Configure(binding => binding.InThreadScope())); // TransientScope wouldn't dispose disposables
+                .Configure(binding => binding.InThreadScope().Intercept().With<FatalExceptionInterceptor>())); // TransientScope wouldn't dispose disposables
         }
 
         // note: settings namespace classes are injected in singleton scope
diff --git a/RetailCoder.VBE/Rubberduck.csproj b/RetailCoder.VBE/Rubberduck.csproj
@@ -391,6 +391,7 @@
     <Compile Include="Refactorings\ExtractMethod\IExtractMethodProc.cs" />
     <Compile Include="Refactorings\ExtractMethod\IExtractMethodRule.cs" />
     <Compile Include="Refactorings\ExtractMethod\IExtractMethodSelectionValidation.cs" />
+    <Compile Include="Root\FatalExceptionInterceptor.cs" />
     <Compile Include="Root\EnumerableCounterInterceptor.cs" />
     <Compile Include="Root\InterceptedException.cs" />
     <Compile Include="Root\InterceptorBase.cs" />
diff --git a/RetailCoder.VBE/UI/SourceControl/BranchesViewViewModel.cs b/RetailCoder.VBE/UI/SourceControl/BranchesViewViewModel.cs
@@ -124,11 +124,11 @@ public string CurrentBranch
                     {
                         RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);
                     }
-                    catch (Exception e)
+                    catch
                     {
-                        Logger.Fatal(e);
                         RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,
                             RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);
+                        throw;
                     }
                     OnLoadingComponentsCompleted();
                 }
@@ -307,11 +307,11 @@ private void CreateBranchOk()
             {
                 RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,
                     RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);
+                throw;
             }
 
             DisplayCreateBranchGrid = false;
@@ -342,11 +342,11 @@ private void MergeBranchOk()
                 OnLoadingComponentsCompleted();
                 return;
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,
                     RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);
+                throw;
             }
 
             DisplayMergeBranchesGrid = false;
@@ -371,11 +371,11 @@ private void DeleteBranch(bool isBranchPublished)
             {
                 RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,
                     RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);
+                throw;
             }
 
             RefreshView();
@@ -400,11 +400,11 @@ private void PublishBranch()
             {
                 RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,
                     RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);
+                throw;
             }
 
             RefreshView();
@@ -421,11 +421,11 @@ private void UnpublishBranch()
             {
                 RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,
                     RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);
+                throw;
             }
 
             RefreshView();
diff --git a/RetailCoder.VBE/UI/SourceControl/ChangesViewViewModel.cs b/RetailCoder.VBE/UI/SourceControl/ChangesViewViewModel.cs
@@ -148,11 +148,11 @@ private void UndoChanges(IFileStatusEntry fileStatusEntry)
             {
                 RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,
                     RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);
+                throw;
             }
         }
 
@@ -203,11 +203,11 @@ private void Commit()
             {
                 RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,
                     RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);
+                throw;
             }
 
             CommitMessage = string.Empty;
diff --git a/RetailCoder.VBE/UI/SourceControl/SourceControlViewViewModel.cs b/RetailCoder.VBE/UI/SourceControl/SourceControlViewViewModel.cs
@@ -604,12 +604,12 @@ private void InitRepo()
                     ViewModel_ErrorThrown(this,
                         new ErrorEventArgs(ex.Message, ex.InnerException.Message, NotificationType.Error));
                 }
-                catch (Exception e)
+                catch
                 {
-                    Logger.Fatal(e);
                     ViewModel_ErrorThrown(this,
                         new ErrorEventArgs(RubberduckUI.SourceControl_UnknownErrorTitle,
                             RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error));
+                    throw;
                 }
 
                 Status = RubberduckUI.Online;
@@ -684,12 +684,12 @@ private void OpenRepo()
                     ViewModel_ErrorThrown(null, new ErrorEventArgs(ex.Message, ex.InnerException.Message, NotificationType.Error));
                     return;
                 }
-                catch (Exception e)
+                catch
                 {
-                    Logger.Fatal(e);
                     ViewModel_ErrorThrown(this,
                         new ErrorEventArgs(RubberduckUI.SourceControl_UnknownErrorTitle,
                             RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error));
+                    throw;
                 }
 
                 OnOpenRepoCompleted();
@@ -731,12 +731,12 @@ private void CloneRepo(SecureCredentials credentials = null)
                 ViewModel_ErrorThrown(this, new ErrorEventArgs(ex.Message, ex.InnerException.Message, NotificationType.Error));
                 return;
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 ViewModel_ErrorThrown(this,
                     new ErrorEventArgs(RubberduckUI.SourceControl_UnknownErrorTitle,
                         RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error));
+                throw;
             }
 
             _isCloning = false;
@@ -766,12 +766,12 @@ private void PublishRepo()
             {
                 ViewModel_ErrorThrown(null, new ErrorEventArgs(ex.Message, ex.InnerException.Message, NotificationType.Error));
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 ViewModel_ErrorThrown(this,
                     new ErrorEventArgs(RubberduckUI.SourceControl_UnknownErrorTitle,
                         RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error));
+                throw;
             }
 
             OnPropertyChanged("RepoDoesNotHaveRemoteLocation");
@@ -809,11 +809,12 @@ private void OpenCommandPrompt()
             {
                 Process.Start(_config.CommandPromptLocation);
             }
-            catch (Exception e)
+            catch
             {
                 ViewModel_ErrorThrown(this,
-                    new ErrorEventArgs(RubberduckUI.SourceControl_OpenCommandPromptFailureTitle, e.Message,
-                        NotificationType.Error));
+                    new ErrorEventArgs(RubberduckUI.SourceControl_UnknownErrorTitle,
+                        RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error));
+                throw;
             }
         }
 
@@ -840,12 +841,12 @@ private void OpenRepoAssignedToProject()
                 _config.Repositories.Remove(_config.Repositories.FirstOrDefault(repo => repo.Id == _vbe.ActiveVBProject.HelpFile));
                 _configService.Save(_config);
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 ViewModel_ErrorThrown(this,
                     new ErrorEventArgs(RubberduckUI.SourceControl_UnknownErrorTitle,
                         RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error));
+                throw;
             }
 
             OnOpenRepoCompleted();
diff --git a/RetailCoder.VBE/UI/SourceControl/UnsyncedCommitsViewViewModel.cs b/RetailCoder.VBE/UI/SourceControl/UnsyncedCommitsViewViewModel.cs
@@ -106,11 +106,11 @@ private void FetchCommits()
             {
                 RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,
                     RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);
+                throw;
             }
         }
 
@@ -127,11 +127,11 @@ private void PullCommits()
             {
                 RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,
                     RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);
+                throw;
             }
         }
 
@@ -148,11 +148,11 @@ private void PushCommits()
             {
                 RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,
                     RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);
+                throw;
             }
         }
 
@@ -170,11 +170,11 @@ private void SyncCommits()
             {
                 RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);
             }
-            catch (Exception e)
+            catch
             {
-                Logger.Fatal(e);
                 RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,
                     RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);
+                throw;
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ private void ApplyDefaultInterfacesConvention(IEnumerable<Assembly> assemblies)`
`170`	`170`	`// inspections & factories have their own binding rules`
`171`	`171`	`.Where(type => !type.Name.EndsWith("Factory") && !type.Name.EndsWith("ConfigProvider") && !type.GetInterfaces().Contains(typeof(IInspection)))`
`172`	`172`	`.BindDefaultInterface()`
`173`		`- .Configure(binding => binding.InThreadScope())); // TransientScope wouldn't dispose disposables`
	`173`	`+ .Configure(binding => binding.InThreadScope().Intercept().With<FatalExceptionInterceptor>())); // TransientScope wouldn't dispose disposables`
`174`	`174`	`}`
`175`	`175`
`176`	`176`	`// note: settings namespace classes are injected in singleton scope`
Original file line number	Diff line number	Diff line change
`@@ -124,11 +124,11 @@ public string CurrentBranch`
`124`	`124`	`{`
`125`	`125`	`RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);`
`126`	`126`	`}`
`127`		`- catch (Exception e)`
	`127`	`+ catch`
`128`	`128`	`{`
`129`		`- Logger.Fatal(e);`
`130`	`129`	`RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,`
`131`	`130`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);`
	`131`	`+ throw;`
`132`	`132`	`}`
`133`	`133`	`OnLoadingComponentsCompleted();`
`134`	`134`	`}`
`@@ -307,11 +307,11 @@ private void CreateBranchOk()`
`307`	`307`	`{`
`308`	`308`	`RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);`
`309`	`309`	`}`
`310`		`- catch (Exception e)`
	`310`	`+ catch`
`311`	`311`	`{`
`312`		`- Logger.Fatal(e);`
`313`	`312`	`RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,`
`314`	`313`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);`
	`314`	`+ throw;`
`315`	`315`	`}`
`316`	`316`
`317`	`317`	`DisplayCreateBranchGrid = false;`
`@@ -342,11 +342,11 @@ private void MergeBranchOk()`
`342`	`342`	`OnLoadingComponentsCompleted();`
`343`	`343`	`return;`
`344`	`344`	`}`
`345`		`- catch (Exception e)`
	`345`	`+ catch`
`346`	`346`	`{`
`347`		`- Logger.Fatal(e);`
`348`	`347`	`RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,`
`349`	`348`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);`
	`349`	`+ throw;`
`350`	`350`	`}`
`351`	`351`
`352`	`352`	`DisplayMergeBranchesGrid = false;`
`@@ -371,11 +371,11 @@ private void DeleteBranch(bool isBranchPublished)`
`371`	`371`	`{`
`372`	`372`	`RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);`
`373`	`373`	`}`
`374`		`- catch (Exception e)`
	`374`	`+ catch`
`375`	`375`	`{`
`376`		`- Logger.Fatal(e);`
`377`	`376`	`RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,`
`378`	`377`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);`
	`378`	`+ throw;`
`379`	`379`	`}`
`380`	`380`
`381`	`381`	`RefreshView();`
`@@ -400,11 +400,11 @@ private void PublishBranch()`
`400`	`400`	`{`
`401`	`401`	`RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);`
`402`	`402`	`}`
`403`		`- catch (Exception e)`
	`403`	`+ catch`
`404`	`404`	`{`
`405`		`- Logger.Fatal(e);`
`406`	`405`	`RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,`
`407`	`406`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);`
	`407`	`+ throw;`
`408`	`408`	`}`
`409`	`409`
`410`	`410`	`RefreshView();`
`@@ -421,11 +421,11 @@ private void UnpublishBranch()`
`421`	`421`	`{`
`422`	`422`	`RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);`
`423`	`423`	`}`
`424`		`- catch (Exception e)`
	`424`	`+ catch`
`425`	`425`	`{`
`426`		`- Logger.Fatal(e);`
`427`	`426`	`RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,`
`428`	`427`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);`
	`428`	`+ throw;`
`429`	`429`	`}`
`430`	`430`
`431`	`431`	`RefreshView();`
Original file line number	Diff line number	Diff line change
`@@ -148,11 +148,11 @@ private void UndoChanges(IFileStatusEntry fileStatusEntry)`
`148`	`148`	`{`
`149`	`149`	`RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);`
`150`	`150`	`}`
`151`		`- catch (Exception e)`
	`151`	`+ catch`
`152`	`152`	`{`
`153`		`- Logger.Fatal(e);`
`154`	`153`	`RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,`
`155`	`154`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);`
	`155`	`+ throw;`
`156`	`156`	`}`
`157`	`157`	`}`
`158`	`158`
`@@ -203,11 +203,11 @@ private void Commit()`
`203`	`203`	`{`
`204`	`204`	`RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);`
`205`	`205`	`}`
`206`		`- catch (Exception e)`
	`206`	`+ catch`
`207`	`207`	`{`
`208`		`- Logger.Fatal(e);`
`209`	`208`	`RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,`
`210`	`209`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);`
	`210`	`+ throw;`
`211`	`211`	`}`
`212`	`212`
`213`	`213`	`CommitMessage = string.Empty;`
Original file line number	Diff line number	Diff line change
`@@ -604,12 +604,12 @@ private void InitRepo()`
`604`	`604`	`ViewModel_ErrorThrown(this,`
`605`	`605`	`new ErrorEventArgs(ex.Message, ex.InnerException.Message, NotificationType.Error));`
`606`	`606`	`}`
`607`		`- catch (Exception e)`
	`607`	`+ catch`
`608`	`608`	`{`
`609`		`- Logger.Fatal(e);`
`610`	`609`	`ViewModel_ErrorThrown(this,`
`611`	`610`	`new ErrorEventArgs(RubberduckUI.SourceControl_UnknownErrorTitle,`
`612`	`611`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error));`
	`612`	`+ throw;`
`613`	`613`	`}`
`614`	`614`
`615`	`615`	`Status = RubberduckUI.Online;`
`@@ -684,12 +684,12 @@ private void OpenRepo()`
`684`	`684`	`ViewModel_ErrorThrown(null, new ErrorEventArgs(ex.Message, ex.InnerException.Message, NotificationType.Error));`
`685`	`685`	`return;`
`686`	`686`	`}`
`687`		`- catch (Exception e)`
	`687`	`+ catch`
`688`	`688`	`{`
`689`		`- Logger.Fatal(e);`
`690`	`689`	`ViewModel_ErrorThrown(this,`
`691`	`690`	`new ErrorEventArgs(RubberduckUI.SourceControl_UnknownErrorTitle,`
`692`	`691`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error));`
	`692`	`+ throw;`
`693`	`693`	`}`
`694`	`694`
`695`	`695`	`OnOpenRepoCompleted();`
`@@ -731,12 +731,12 @@ private void CloneRepo(SecureCredentials credentials = null)`
`731`	`731`	`ViewModel_ErrorThrown(this, new ErrorEventArgs(ex.Message, ex.InnerException.Message, NotificationType.Error));`
`732`	`732`	`return;`
`733`	`733`	`}`
`734`		`- catch (Exception e)`
	`734`	`+ catch`
`735`	`735`	`{`
`736`		`- Logger.Fatal(e);`
`737`	`736`	`ViewModel_ErrorThrown(this,`
`738`	`737`	`new ErrorEventArgs(RubberduckUI.SourceControl_UnknownErrorTitle,`
`739`	`738`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error));`
	`739`	`+ throw;`
`740`	`740`	`}`
`741`	`741`
`742`	`742`	`_isCloning = false;`
`@@ -766,12 +766,12 @@ private void PublishRepo()`
`766`	`766`	`{`
`767`	`767`	`ViewModel_ErrorThrown(null, new ErrorEventArgs(ex.Message, ex.InnerException.Message, NotificationType.Error));`
`768`	`768`	`}`
`769`		`- catch (Exception e)`
	`769`	`+ catch`
`770`	`770`	`{`
`771`		`- Logger.Fatal(e);`
`772`	`771`	`ViewModel_ErrorThrown(this,`
`773`	`772`	`new ErrorEventArgs(RubberduckUI.SourceControl_UnknownErrorTitle,`
`774`	`773`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error));`
	`774`	`+ throw;`
`775`	`775`	`}`
`776`	`776`
`777`	`777`	`OnPropertyChanged("RepoDoesNotHaveRemoteLocation");`
`@@ -809,11 +809,12 @@ private void OpenCommandPrompt()`
`809`	`809`	`{`
`810`	`810`	`Process.Start(_config.CommandPromptLocation);`
`811`	`811`	`}`
`812`		`- catch (Exception e)`
	`812`	`+ catch`
`813`	`813`	`{`
`814`	`814`	`ViewModel_ErrorThrown(this,`
`815`		`- new ErrorEventArgs(RubberduckUI.SourceControl_OpenCommandPromptFailureTitle, e.Message,`
`816`		`- NotificationType.Error));`
	`815`	`+ new ErrorEventArgs(RubberduckUI.SourceControl_UnknownErrorTitle,`
	`816`	`+ RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error));`
	`817`	`+ throw;`
`817`	`818`	`}`
`818`	`819`	`}`
`819`	`820`
`@@ -840,12 +841,12 @@ private void OpenRepoAssignedToProject()`
`840`	`841`	`_config.Repositories.Remove(_config.Repositories.FirstOrDefault(repo => repo.Id == _vbe.ActiveVBProject.HelpFile));`
`841`	`842`	`_configService.Save(_config);`
`842`	`843`	`}`
`843`		`- catch (Exception e)`
	`844`	`+ catch`
`844`	`845`	`{`
`845`		`- Logger.Fatal(e);`
`846`	`846`	`ViewModel_ErrorThrown(this,`
`847`	`847`	`new ErrorEventArgs(RubberduckUI.SourceControl_UnknownErrorTitle,`
`848`	`848`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error));`
	`849`	`+ throw;`
`849`	`850`	`}`
`850`	`851`
`851`	`852`	`OnOpenRepoCompleted();`
Original file line number	Diff line number	Diff line change
`@@ -106,11 +106,11 @@ private void FetchCommits()`
`106`	`106`	`{`
`107`	`107`	`RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);`
`108`	`108`	`}`
`109`		`- catch (Exception e)`
	`109`	`+ catch`
`110`	`110`	`{`
`111`		`- Logger.Fatal(e);`
`112`	`111`	`RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,`
`113`	`112`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);`
	`113`	`+ throw;`
`114`	`114`	`}`
`115`	`115`	`}`
`116`	`116`
`@@ -127,11 +127,11 @@ private void PullCommits()`
`127`	`127`	`{`
`128`	`128`	`RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);`
`129`	`129`	`}`
`130`		`- catch (Exception e)`
	`130`	`+ catch`
`131`	`131`	`{`
`132`		`- Logger.Fatal(e);`
`133`	`132`	`RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,`
`134`	`133`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);`
	`134`	`+ throw;`
`135`	`135`	`}`
`136`	`136`	`}`
`137`	`137`
`@@ -148,11 +148,11 @@ private void PushCommits()`
`148`	`148`	`{`
`149`	`149`	`RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);`
`150`	`150`	`}`
`151`		`- catch (Exception e)`
	`151`	`+ catch`
`152`	`152`	`{`
`153`		`- Logger.Fatal(e);`
`154`	`153`	`RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,`
`155`	`154`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);`
	`155`	`+ throw;`
`156`	`156`	`}`
`157`	`157`	`}`
`158`	`158`
`@@ -170,11 +170,11 @@ private void SyncCommits()`
`170`	`170`	`{`
`171`	`171`	`RaiseErrorEvent(ex.Message, ex.InnerException.Message, NotificationType.Error);`
`172`	`172`	`}`
`173`		`- catch (Exception e)`
	`173`	`+ catch`
`174`	`174`	`{`
`175`		`- Logger.Fatal(e);`
`176`	`175`	`RaiseErrorEvent(RubberduckUI.SourceControl_UnknownErrorTitle,`
`177`	`176`	`RubberduckUI.SourceControl_UnknownErrorMessage, NotificationType.Error);`
	`177`	`+ throw;`
`178`	`178`	`}`
`179`	`179`	`}`
`180`	`180`