General settings tests

Author: Hosch250

RetailCoder.VBE/Settings/ConfigurationLoader.cs

@@ -137,8 +137,8 @@ private GeneralSettings GetDefaultGeneralSettings()
             return new GeneralSettings(new DisplayLanguageSetting("en-US"),
                 new[]
                 {
-                    new Hotkey{Name="IndentModule", IsEnabled=true, KeyDisplaySymbol="CTRL-M",},
-                    new Hotkey{Name="IndentProcedure", IsEnabled=true, KeyDisplaySymbol="CTRL-P"}
+                    new Hotkey{Name="IndentProcedure", IsEnabled=true, KeyDisplaySymbol="CTRL-P"},
+                    new Hotkey{Name="IndentModule", IsEnabled=true, KeyDisplaySymbol="CTRL-M"}
                 });
         }
 

RetailCoder.VBE/UI/Settings/GeneralSettingsViewModel.cs

@@ -1,7 +1,5 @@
-using System.Collections.Generic;
-using System.Collections.ObjectModel;
+using System.Collections.ObjectModel;
 using System.Linq;
-using Rubberduck.Common;
 using Rubberduck.Settings;
 
 namespace Rubberduck.UI.Settings

RetailCoder.VBE/UI/Settings/IndenterSettingsViewModel.cs

@@ -1,7 +1,5 @@
-using System.Windows.Input;
-using Rubberduck.Settings;
+using Rubberduck.Settings;
 using Rubberduck.SmartIndenter;
-using Rubberduck.UI.Command;
 
 namespace Rubberduck.UI.Settings
 {

RubberduckTests/RubberduckTests.csproj

@@ -120,6 +120,7 @@
     <Compile Include="Refactoring\ReorderParametersTests.cs" />
     <Compile Include="RubberduckParserTests.cs" />
     <Compile Include="Settings\CodeInspectionSettingsTests.cs" />
+    <Compile Include="Settings\GeneralSettingsTests.cs" />
     <Compile Include="Settings\TodoSettingsTests.cs" />
     <Compile Include="Settings\UnitTestSettingsTests.cs" />
     <Compile Include="SourceControlConfig.cs" />

RubberduckTests/Settings/GeneralSettingsTests.cs

@@ -0,0 +1,89 @@
+using System.Linq;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Rubberduck.Settings;
+using Rubberduck.UI.Settings;
+using GeneralSettings = Rubberduck.Settings.GeneralSettings;
+
+namespace RubberduckTests.Settings
+{
+    [TestClass]
+    public class GeneralSettingsTests
+    {
+        private Configuration GetDefaultConfig()
+        {
+            var generalSettings = new GeneralSettings
+            {
+                Language = new DisplayLanguageSetting("en-US"),
+                HotkeySettings = new[]
+                {
+                    new Hotkey{Name="IndentProcedure", IsEnabled=true, KeyDisplaySymbol="CTRL-P"},
+                    new Hotkey{Name="IndentModule", IsEnabled=true, KeyDisplaySymbol="CTRL-M"}
+                }
+            };
+
+            var userSettings = new UserSettings(generalSettings, null, null, null, null);
+            return new Configuration(userSettings);
+        }
+
+        private Configuration GetNondefaultConfig()
+        {
+            var generalSettings = new GeneralSettings
+            {
+                Language = new DisplayLanguageSetting("sv-SE"),
+                HotkeySettings = new[]
+                {
+                    new Hotkey{Name="IndentProcedure", IsEnabled=false, KeyDisplaySymbol="CTRL-C"},
+                    new Hotkey{Name="IndentModule", IsEnabled=false, KeyDisplaySymbol="CTRL-X"}
+                }
+            };
+
+            var userSettings = new UserSettings(generalSettings, null, null, null, null);
+            return new Configuration(userSettings);
+        }
+
+        [TestMethod]
+        public void SaveConfigWorks()
+        {
+            var customConfig = GetNondefaultConfig();
+            var viewModel = new GeneralSettingsViewModel(customConfig);
+
+            var config = GetDefaultConfig();
+            viewModel.UpdateConfig(config);
+
+            MultiAssert.Aggregate(
+                () => Assert.AreEqual(config.UserSettings.GeneralSettings.Language, viewModel.SelectedLanguage),
+                () => Assert.IsTrue(config.UserSettings.GeneralSettings.HotkeySettings.SequenceEqual(viewModel.Hotkeys)));
+        }
+
+        [TestMethod]
+        public void SetDefaultsWorks()
+        {
+            var viewModel = new GeneralSettingsViewModel(GetNondefaultConfig());
+
+            var defaultConfig = GetDefaultConfig();
+            viewModel.SetToDefaults(defaultConfig);
+
+            MultiAssert.Aggregate(
+                () => Assert.AreEqual(defaultConfig.UserSettings.GeneralSettings.Language, viewModel.SelectedLanguage),
+                () => Assert.IsTrue(defaultConfig.UserSettings.GeneralSettings.HotkeySettings.SequenceEqual(viewModel.Hotkeys)));
+        }
+
+        [TestMethod]
+        public void LanguageIsSetInCtor()
+        {
+            var defaultConfig = GetDefaultConfig();
+            var viewModel = new GeneralSettingsViewModel(defaultConfig);
+
+            Assert.AreEqual(defaultConfig.UserSettings.GeneralSettings.Language, viewModel.SelectedLanguage);
+        }
+
+        [TestMethod]
+        public void HotkeysAreSetInCtor()
+        {
+            var defaultConfig = GetDefaultConfig();
+            var viewModel = new GeneralSettingsViewModel(defaultConfig);
+
+            Assert.IsTrue(defaultConfig.UserSettings.GeneralSettings.HotkeySettings.SequenceEqual(viewModel.Hotkeys));
+        }
+    }
+}