attempt to make hook failures less fatal

Author: retailcoder

RetailCoder.VBE/Common/Hotkeys/Hotkey.cs

@@ -63,7 +63,7 @@ public void Detach()
         {
             if (!IsAttached)
             {
-                throw new InvalidOperationException(Rubberduck.UI.RubberduckUI.CommonHotkey_HookDetached);
+                return;
             }
 
             User32.UnregisterHotKey(_hWndVbe, HotkeyInfo.HookId);
@@ -76,7 +76,7 @@ private void HookKey(Keys key, uint shift)
         {
             if (IsAttached)
             {
-                throw new InvalidOperationException(Rubberduck.UI.RubberduckUI.CommonHotkey_HookAttached);
+                return;
             }
 
             var hookId = (IntPtr)Kernel32.GlobalAddAtom(Guid.NewGuid().ToString());

RetailCoder.VBE/Common/KeyboardHook.cs

@@ -112,6 +112,8 @@ public void Detach()
 
             if (!User32.UnhookWindowsHookEx(_hookId))
             {
+                IsAttached = false;
+                _hookId = IntPtr.Zero;
                 throw new Win32Exception();
             }
 

RetailCoder.VBE/Common/RubberduckHooks.cs

@@ -109,8 +109,8 @@ public void Detach()
             {
                 foreach (var hook in Hooks)
                 {
-                    hook.Detach();
                     hook.MessageReceived -= hook_MessageReceived;
+                    hook.Detach();
                 }
             }
             catch (Win32Exception exception)

RetailCoder.VBE/UI/Command/Refactorings/RefactorIntroduceParameterCommand.cs

@@ -31,7 +31,7 @@ public override bool CanExecute(object parameter)
             var selection = Vbe.ActiveCodePane.GetSelection();
             var target = _state.AllUserDeclarations.FindTarget(selection, new []{DeclarationType.Variable, DeclarationType.Constant});
 
-            var canExecute = target != null && target.ParentScopeDeclaration.DeclarationType.HasFlag(DeclarationType.Member);
+            var canExecute = target != null && target.ParentScopeDeclaration != null && target.ParentScopeDeclaration.DeclarationType.HasFlag(DeclarationType.Member);
 
             Debug.WriteLine("{0}.CanExecute evaluates to {1}", GetType().Name, canExecute);
             return canExecute;