Merge pull request #2578 from comintern/next

Fix extensible attribute on coclasses, reserialize, reenable tests.

Author: comintern

Rubberduck.Parsing/ComReflection/ComModule.cs

@@ -24,6 +24,11 @@ public ComMember DefaultMember
             get { return null; }
         }
 
+        public bool IsExtensible
+        {
+            get { return false; }
+        }
+
         private readonly List<ComField> _fields = new List<ComField>();
         public IEnumerable<ComField> Fields
         {

Rubberduck.Parsing/ComReflection/ComType.cs

@@ -9,13 +9,14 @@ public interface IComType : IComBase
         bool IsAppObject { get; }
         bool IsPreDeclared { get; }
         bool IsHidden { get; }
-        bool IsRestricted { get; }       
+        bool IsRestricted { get; }
     }
 
     public interface IComTypeWithMembers : IComType
     {
         IEnumerable<ComMember> Members { get; }
         ComMember DefaultMember { get; }
+        bool IsExtensible { get; }
     }
 
     public interface IComTypeWithFields : IComType

Rubberduck.Parsing/ComReflection/ReferencedDeclarationsCollector.cs

@@ -205,7 +205,7 @@ private static Attributes GetModuleAttributes(IComType module)
             {
                 attributes.AddGlobalClassAttribute();
             }
-            if (module as ComInterface != null && ((ComInterface)module).IsExtensible)
+            if (module as IComTypeWithMembers != null && ((IComTypeWithMembers)module).IsExtensible)
             {
                 attributes.AddExtensibledClassAttribute();
             }

RubberduckTests/Inspections/MemberNotOnInterfaceInspectionTests.cs

@@ -38,7 +38,6 @@ private static ParseCoordinator ArrangeParser(string inputCode)
         [TestCategory("Inspections")]
         public void MemberNotOnInterface_ReturnsResult_UnDeclaredMember()
         {
-            Assert.Inconclusive("Pending post-merge fix.");
             const string inputCode =
 @"Sub Foo()
     Dim dict As Dictionary
@@ -63,7 +62,6 @@ Dim dict As Dictionary
         [TestCategory("Inspections")]
         public void MemberNotOnInterface_ReturnsResult_UnDeclaredInterfaceMember()
         {
-            Assert.Inconclusive("Pending post-merge fix.");
             const string inputCode =
 @"Sub Foo()
     Dim dict As Dictionary
@@ -88,7 +86,6 @@ Dim dict As Dictionary
         [TestCategory("Inspections")]
         public void MemberNotOnInterface_ReturnsResult_UnDeclaredMemberOnParameter()
         {
-            Assert.Inconclusive("Pending post-merge fix.");
             const string inputCode =
 @"Sub Foo(dict As Dictionary)
     dict.NonMember

RubberduckTests/Inspections/ObjectVariableNotSetInpsectionTests.cs

@@ -178,7 +178,6 @@ Dim target As Range
         [TestCategory("Inspections")]
         public void ObjectVariableNotSet_FunctionReturnsArrayOfType_ReturnsNoResult()
         {
-            Assert.Inconclusive("Pending reserialization.");
             const string inputCode = @"
 Private Function GetSomeDictionaries() As Dictionary()
     Dim temp(0 To 1) As Worksheet