Unit test tests (#1659)

* A few tests.

* A bunch of unit test UI tests.

Author: Hosch250

RetailCoder.VBE/UI/Command/MenuItems/UiDispatcher.cs

@@ -8,7 +8,7 @@ public static class UiDispatcher
         // thanks to Pellared on http://stackoverflow.com/a/12909070/1188513
 
         private static SynchronizationContext UiContext { get; set; }
-
+        
         public static void Initialize()
         {
             if (UiContext == null)

RetailCoder.VBE/UI/UnitTesting/TestExplorerModel.cs

@@ -2,6 +2,7 @@
 using System.Collections.ObjectModel;
 using System.Linq;
 using System.Windows.Media;
+using System.Windows.Threading;
 using Microsoft.Vbe.Interop;
 using Rubberduck.Parsing.VBA;
 using Rubberduck.UI.Command.MenuItems;
@@ -13,12 +14,15 @@ public class TestExplorerModel : ViewModelBase
     {
         private readonly VBE _vbe;
         private readonly RubberduckParserState _state;
+        private readonly Dispatcher _dispatcher;
 
         public TestExplorerModel(VBE vbe, RubberduckParserState state)
         {
             _vbe = vbe;
             _state = state;
             _state.StateChanged += State_StateChanged;
+
+            _dispatcher = Dispatcher.CurrentDispatcher;
         }
 
         private void State_StateChanged(object sender, ParserStateEventArgs e)
@@ -33,34 +37,38 @@ private void State_StateChanged(object sender, ParserStateEventArgs e)
                                  t.Declaration.IdentifierName == test.Declaration.IdentifierName &&
                                  t.Declaration.ProjectId == test.Declaration.ProjectId)).ToList();
 
-            // remove old tests
-            foreach (var test in removedTests)
+            _dispatcher.Invoke(() =>
             {
-                UiDispatcher.Invoke(() => { Tests.Remove(test); });
-            }
 
-            // update declarations for existing tests--declarations are immutable
-            foreach (var test in Tests.Except(removedTests))
-            {
-                var declaration = tests.First(t =>
-                    t.Declaration.ComponentName == test.Declaration.ComponentName &&
-                    t.Declaration.IdentifierName == test.Declaration.IdentifierName &&
-                    t.Declaration.ProjectId == test.Declaration.ProjectId).Declaration;
+                // remove old tests
+                foreach (var test in removedTests)
+                {
+                    Tests.Remove(test);
+                }
 
-                test.SetDeclaration(declaration);
-            }
+                // update declarations for existing tests--declarations are immutable
+                foreach (var test in Tests.Except(removedTests))
+                {
+                    var declaration = tests.First(t =>
+                        t.Declaration.ComponentName == test.Declaration.ComponentName &&
+                        t.Declaration.IdentifierName == test.Declaration.IdentifierName &&
+                        t.Declaration.ProjectId == test.Declaration.ProjectId).Declaration;
 
-            // add new tests
-            foreach (var test in tests)
-            {
-                if (!Tests.Any(t =>
-                    t.Declaration.ComponentName == test.Declaration.ComponentName &&
-                    t.Declaration.IdentifierName == test.Declaration.IdentifierName &&
-                    t.Declaration.ProjectId == test.Declaration.ProjectId))
+                    test.SetDeclaration(declaration);
+                }
+
+                // add new tests
+                foreach (var test in tests)
                 {
-                    UiDispatcher.Invoke(() => { Tests.Add(test); });
+                    if (!Tests.Any(t =>
+                        t.Declaration.ComponentName == test.Declaration.ComponentName &&
+                        t.Declaration.IdentifierName == test.Declaration.IdentifierName &&
+                        t.Declaration.ProjectId == test.Declaration.ProjectId))
+                    {
+                        Tests.Add(test);
+                    }
                 }
-            }
+            });
         }
 
         private readonly ObservableCollection<TestMethod> _tests = new ObservableCollection<TestMethod>();

Rubberduck.VBEEditor/QualifiedModuleName.cs

@@ -30,12 +30,15 @@ private static string GetDisplayName(VBProject project)
                 //Eg. A Workbook's parent is the application, so read the workbook's name
                 try
                 {
-                    var nameProperty = project.VBComponents.Cast<VBComponent>()
+                    var component = project.VBComponents.Cast<VBComponent>()
                         .FirstOrDefault(comp => comp.Type == vbext_ComponentType.vbext_ct_Document
                                                 && comp.Properties.Item("Name").Value != null
                                                 && comp.Properties.Item("Parent")
-                                                .Object.Equals(comp.Properties.Item("Application").Object))
-                                                .Properties.Cast<Property>().FirstOrDefault(property => property.Name == "Name");
+                                                    .Object.Equals(comp.Properties.Item("Application").Object));
+
+                    if (component == null) { return null; }
+
+                    var nameProperty = component.Properties.Cast<Property>().FirstOrDefault(property => property.Name == "Name");
                     return nameProperty == null
                         ? null
                         : nameProperty.Value.ToString();

RubberduckTests/Mocks/MockProjectBuilder.cs

@@ -21,7 +21,6 @@ public class MockProjectBuilder
         private readonly Mock<References> _vbReferences;
 
         private readonly List<Mock<VBComponent>> _componentsMock = new List<Mock<VBComponent>>();
-        //private readonly List<VBComponent> _components = new List<VBComponent>();
         private readonly List<Reference> _references = new List<Reference>();
 
         public Mock<VBComponents> MockVBComponents
@@ -39,6 +38,11 @@ private List<VBComponent> Components
             get { return _componentsMock.Select(m => m.Object).ToList(); }
         }
 
+        public void RemoveComponent(Mock<VBComponent> component)
+        {
+            _componentsMock.Remove(component);
+        }
+
         public MockProjectBuilder(string name, string filename, vbext_ProjectProtection protection, Func<VBE> getVbe, MockVbeBuilder mockVbeBuilder)
         {
             _getVbe = getVbe;

RubberduckTests/RubberduckTests.csproj

@@ -172,6 +172,7 @@
     <Compile Include="UnitTesting\AssertTests.cs" />
     <Compile Include="UnitTesting\EngineTests.cs" />
     <Compile Include="UnitTesting\DiscoveryTests.cs" />
+    <Compile Include="UnitTesting\ViewModelTests.cs" />
     <Compile Include="VbeTestBase.cs" />
   </ItemGroup>
   <ItemGroup>

RubberduckTests/UnitTesting/DiscoveryTests.cs

@@ -1,8 +1,11 @@
 using System.Linq;
+using System.Threading;
 using Microsoft.Vbe.Interop;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using Moq;
 using Rubberduck.Parsing.VBA;
+using Rubberduck.UI.Command.MenuItems;
+using Rubberduck.UI.UnitTesting;
 using Rubberduck.UnitTesting;
 using Rubberduck.VBEditor;
 using Rubberduck.VBEditor.VBEHost;