Merge pull request #3678 from bclothier/MinorTweaks

Minor tweaks

Author: retailcoder

RetailCoder.VBE/Common/Hotkeys/Hotkey.cs

@@ -80,6 +80,8 @@ public void Detach()
             {
                 Logger.Warn($"Error calling DeleteGlobalAtom; the error was {lastError}, the id {HotkeyInfo.HookId} and the type of the associated command {Command.GetType()}.");
             }
+
+            HotkeyInfo = new HotkeyInfo(IntPtr.Zero, Combo);
             ClearCommandShortcutText();
         }
 
@@ -101,9 +103,11 @@ private void HookKey(Keys key, uint shift)
             if (!success)
             {
                 Logger.Debug(RubberduckUI.CommonHotkey_KeyNotRegistered, key);
+                return;
             }
 
             HotkeyInfo = new HotkeyInfo(hookId, Combo);
+            Logger.Trace($"Hotkey for the associated command {Command.GetType()} was registered with id {HotkeyInfo.HookId}");
         }
 
         private void SetCommandShortcutText()

RetailCoder.VBE/Settings/CodeInspectionSettings.cs

@@ -52,7 +52,7 @@ public CodeInspectionSetting GetSetting(Type inspectionType)
                 {
                     return existing;
                 }
-                var proto = Convert.ChangeType(Activator.CreateInstance(inspectionType), inspectionType);
+                var proto = Convert.ChangeType(Activator.CreateInstance(inspectionType, new object[]{null}), inspectionType);
                 var setting = new CodeInspectionSetting(proto as IInspectionModel);
                 CodeInspections.Add(setting);
                 return setting;

RubberduckTests/Inspections/InspectionsHelper.cs

@@ -28,7 +28,8 @@ private static Configuration GetTestConfig(IInspection inspection)
             settings.CodeInspections.Add(new CodeInspectionSetting
             {
                 Description = inspection.Description,
-                Severity = inspection.Severity
+                Severity = inspection.Severity, 
+                Name = inspection.ToString()
             });
             return new Configuration
             {