Skip to content

Commit 3067b2b

Browse files
committed
Add meta and name, fix grammar.
1 parent 02549df commit 3067b2b

File tree

3 files changed

+48
-24
lines changed

3 files changed

+48
-24
lines changed

RetailCoder.VBE/Inspections/InspectionsUI.Designer.cs

Lines changed: 38 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

RetailCoder.VBE/Inspections/InspectionsUI.resx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -268,17 +268,17 @@
268268
<value>Use of variant-returning string function</value>
269269
</data>
270270
<data name="ProcedureShouldBeFunctionInspection" xml:space="preserve">
271-
<value>Procedure '{0}' should be function.</value>
271+
<value>Procedure '{0}' should be a function.</value>
272272
<comment>{0} Procedure name</comment>
273273
</data>
274274
<data name="ProcedureShouldBeFunctionInspectionQuickFix" xml:space="preserve">
275-
<value>Replace Procedure with Function and update usages.</value>
275+
<value>Replace procedure with function and update usages.</value>
276276
</data>
277277
<data name="UseMeaningfulNameInspection" xml:space="preserve">
278278
<value>Consider renaming {0} '{1}'</value>
279279
</data>
280280
<data name="UseMeaningfulNameInspectionMeta" xml:space="preserve">
281-
<value>Identifier names should indicate what they're used for, and should be readable; avoid disemvoweling, numeric suffixes and 1-2 character names.</value>
281+
<value>Identifier names should indicate what they're used for and should be readable; avoid disemvoweling, numeric suffixes, and 1-2 character names.</value>
282282
</data>
283283
<data name="UseMeaningfulNameInspectionName" xml:space="preserve">
284284
<value>Use meaningful names</value>
@@ -307,4 +307,10 @@
307307
<data name="WriteOnlyPropertyInspectionName" xml:space="preserve">
308308
<value>Write-only property</value>
309309
</data>
310+
<data name="ProcedureShouldBeFunctionInspectionMeta" xml:space="preserve">
311+
<value>A procedure has one ByRef parameter. Consider creating a function that returns the value instead.</value>
312+
</data>
313+
<data name="ProcedureShouldBeFunctionInspectionName" xml:space="preserve">
314+
<value>Convert procedure to function</value>
315+
</data>
310316
</root>

RetailCoder.VBE/Inspections/ProcedureShouldBeFunctionInspection.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ public ProcedureShouldBeFunctionInspection()
1414
}
1515

1616
public string Name { get { return "ProcedureShouldBeFunctionInspection"; } }
17+
public string Meta { get { return InspectionsUI.ResourceManager.GetString(Name + "Meta"); } }
1718
public string Description { get { return InspectionsUI.ProcedureShouldBeFunctionInspection; } }
1819
public CodeInspectionType InspectionType { get { return CodeInspectionType.LanguageOpportunities; } }
1920
public CodeInspectionSeverity Severity { get; set; }

0 commit comments

Comments
 (0)