removed extraneous OnStateChanged invocations

Author: retailcoder

Rubberduck.Parsing/VBA/RubberduckParser.cs

@@ -57,12 +57,11 @@ public RubberduckParser(VBE vbe, RubberduckParserState state, IAttributeParser a
             state.StateChanged += StateOnStateChanged;
         }
 
-        private void StateOnStateChanged(object sender, ParserStateEventArgs e)
+        private void StateOnStateChanged(object sender, EventArgs e)
         {
-            Debug.WriteLine("RubberduckParser handles OnStateChanged ({0})", e.State);
-            Debug.Assert(e.State == _state.Status);
+            Debug.WriteLine("RubberduckParser handles OnStateChanged ({0})", _state.Status);
 
-            if (e.State == ParserState.Parsed)
+            if (_state.Status == ParserState.Parsed)
             {
                 Debug.WriteLine("(handling OnStateChanged) Starting resolver task");
                 Resolve(_central.Token); // Tests expect this to be synchronous

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -98,9 +98,8 @@ public void SetModuleState(VBComponent component, ParserState state, SyntaxError
 
             Debug.WriteLine("Module '{0}' state is changing to '{1}' (thread {2})", component.Name, state, Thread.CurrentThread.ManagedThreadId);
             OnModuleStateChanged(component, state);
-            Status = EvaluateParserState();
 
-            OnStateChanged(Status);
+            Status = EvaluateParserState();
         }
 
         private ParserState EvaluateParserState()
@@ -286,7 +285,7 @@ public bool ClearDeclarations(VBComponent component)
         {
             var project = component.Collection.Parent;
             var keys = _declarations.Keys.Where(kvp => 
-                kvp.Project == project && kvp.Component == component);
+                kvp.Project == project && kvp.ComponentName == component.Name); // VBComponent reference seems to mismatch
 
             var success = true;
             foreach (var key in keys)