Merge pull request #3401 from mansellan/next

Fixes issues with GitHub authentication crashing source control on push.

Author: retailcoder

RetailCoder.VBE/UI/SourceControl/SourceControlProviderFactory.cs

@@ -7,6 +7,6 @@ public interface ISourceControlProviderFactory
     {
         ISourceControlProvider CreateProvider(IVBProject project);
         ISourceControlProvider CreateProvider(IVBProject project, IRepository repository);
-        ISourceControlProvider CreateProvider(IVBProject isAny, IRepository repository, SecureCredentials secureCredentials);
+        ISourceControlProvider CreateProvider(IVBProject project, IRepository repository, SecureCredentials secureCredentials);
     }
 }

Rubberduck.SourceControl/GitProvider.cs

@@ -52,13 +52,13 @@ public GitProvider(IVBProject project, IRepository repository, string userName,
             _credentialsHandler = (url, user, cred) => _credentials;
         }
 
-        public GitProvider(IVBProject project, IRepository repository, ICredentials<SecureString> credentials)
+        public GitProvider(IVBProject project, IRepository repository, ICredentials<SecureString> secureCredentials)
             : this(project, repository)
         {
             _credentials = new SecureUsernamePasswordCredentials()
             {
-                Username = credentials.Username,
-                Password = credentials.Password
+                Username = secureCredentials.Username,
+                Password = secureCredentials.Password
             };
 
             _credentialsHandler = (url, user, cred) => _credentials;