Skip to content

Commit 2e518b4

Browse files
committed
Cosmetic changes to the ComWrapperEnumerator.
1 parent 29e0e31 commit 2e518b4

File tree

1 file changed

+16
-12
lines changed

1 file changed

+16
-12
lines changed

Rubberduck.VBEEditor/SafeComWrappers/ComWrapperEnumerator.cs

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace Rubberduck.VBEditor.SafeComWrappers
1414

1515
[ComImport(), Guid("00020400-0000-0000-C000-000000000046")]
1616
[InterfaceType(ComInterfaceType.InterfaceIsIUnknown)]
17-
interface IDispatch
17+
internal interface IDispatch
1818
{
1919
[PreserveSig] int GetTypeInfoCount([Out] out uint pctinfo);
2020
[PreserveSig] int GetTypeInfo([In] uint iTInfo, [In] uint lcid, [Out] out ComTypes.ITypeInfo pTypeInfo);
@@ -31,7 +31,7 @@ int Invoke([In] int dispIdMember,
3131
[Out] out uint pArgErr);
3232
}
3333

34-
class IDispatchHelper
34+
internal class IDispatchHelper
3535
{
3636
public enum StandardDispIds : int
3737
{
@@ -49,13 +49,11 @@ public enum InvokeKind : int
4949
public static object PropertyGet_NoArgs(IDispatch obj, int memberId)
5050
{
5151
var pDispParams = new ComTypes.DISPPARAMS();
52-
object pVarResult;
5352
var pExcepInfo = new ComTypes.EXCEPINFO();
54-
uint ErrArg;
5553
Guid guid = new Guid();
56-
54+
5755
int hr = obj.Invoke(memberId, ref guid, 0, (uint)(InvokeKind.DISPATCH_METHOD | InvokeKind.DISPATCH_PROPERTYGET),
58-
ref pDispParams, out pVarResult, ref pExcepInfo, out ErrArg);
56+
ref pDispParams, out var pVarResult, ref pExcepInfo, out uint ErrArg);
5957

6058
if (hr < 0)
6159
{
@@ -97,11 +95,6 @@ public ComWrapperEnumerator(object source, Func<object, TWrapperItem> itemWrappe
9795
}
9896
}
9997

100-
public void Dispose()
101-
{
102-
if (!IsWrappingNullReference) Marshal.ReleaseComObject(_enumeratorRCW);
103-
}
104-
10598
void IEnumerator.Reset()
10699
{
107100
if (!IsWrappingNullReference)
@@ -121,7 +114,10 @@ void IEnumerator.Reset()
121114

122115
bool IEnumerator.MoveNext()
123116
{
124-
if (IsWrappingNullReference) return false;
117+
if (IsWrappingNullReference)
118+
{
119+
return false;
120+
}
125121

126122
_currentItem = null;
127123

@@ -139,5 +135,13 @@ bool IEnumerator.MoveNext()
139135

140136
return (celtFetched == 1); // celtFetched will be 0 when we reach the end of the collection
141137
}
138+
139+
public void Dispose()
140+
{
141+
if (!IsWrappingNullReference)
142+
{
143+
Marshal.ReleaseComObject(_enumeratorRCW);
144+
}
145+
}
142146
}
143147
}

0 commit comments

Comments
 (0)