added logging for parse exception details

retailcoder · retailcoder · commit 2ba960b4c359 · 2017-03-07T13:34:50.000-05:00
diff --git a/Rubberduck.Parsing/VBA/ComponentParseTask.cs b/Rubberduck.Parsing/VBA/ComponentParseTask.cs
@@ -92,7 +92,7 @@ public void Start(CancellationToken token)
             }
             catch (SyntaxErrorException exception)
             {
-                //System.Diagnostics.Debug.Assert(false, "A RecognitionException should be notified of, not thrown as a SyntaxErrorException. This lets the parser recover from parse errors.");
+                Logger.Warn("Syntax error; offending token '{0}' at line {1}, column {2} in module {3}.", exception.OffendingSymbol.Text, exception.LineNumber, exception.Position, _qualifiedName);
                 Logger.Error(exception, "Exception thrown in thread {0}, ParseTaskID {1}.", Thread.CurrentThread.ManagedThreadId, _taskId);
                 var failedHandler = ParseFailure;
                 if (failedHandler != null)

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ public void Start(CancellationToken token)`
`92`	`92`	`}`
`93`	`93`	`catch (SyntaxErrorException exception)`
`94`	`94`	`{`
`95`		`- //System.Diagnostics.Debug.Assert(false, "A RecognitionException should be notified of, not thrown as a SyntaxErrorException. This lets the parser recover from parse errors.");`
	`95`	`+ Logger.Warn("Syntax error; offending token '{0}' at line {1}, column {2} in module {3}.", exception.OffendingSymbol.Text, exception.LineNumber, exception.Position, _qualifiedName);`
`96`	`96`	`Logger.Error(exception, "Exception thrown in thread {0}, ParseTaskID {1}.", Thread.CurrentThread.ManagedThreadId, _taskId);`
`97`	`97`	`var failedHandler = ParseFailure;`
`98`	`98`	`if (failedHandler != null)`