fixed ProcedureNotUsedInspection to pick up unused functions (i.e. procedures without any non-assignment reference)

retailcoder · retailcoder · commit 2b1ec2a7368b · 2015-06-24T22:58:43.000-04:00
diff --git a/RetailCoder.VBE/Inspections/ProcedureNotUsedInspection.cs b/RetailCoder.VBE/Inspections/ProcedureNotUsedInspection.cs
@@ -61,7 +61,7 @@ private bool IsIgnoredDeclaration(Declarations declarations, Declaration declara
         {
             var enumerable = classes as IList<Declaration> ?? classes.ToList();
             var result = !ProcedureTypes.Contains(declaration.DeclarationType)
-                || declaration.References.Any()
+                || declaration.References.Any(r => !r.IsAssignment)
                 || handlers.Contains(declaration)
                 || IsPublicModuleMember(modules, declaration)
                 || IsClassLifeCycleHandler(enumerable, declaration)

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ private bool IsIgnoredDeclaration(Declarations declarations, Declaration declara`
`61`	`61`	`{`
`62`	`62`	`var enumerable = classes as IList<Declaration> ?? classes.ToList();`
`63`	`63`	`var result = !ProcedureTypes.Contains(declaration.DeclarationType)`
`64`		`- \|\| declaration.References.Any()`
	`64`	`+ \|\| declaration.References.Any(r => !r.IsAssignment)`
`65`	`65`	`\|\| handlers.Contains(declaration)`
`66`	`66`	`\|\| IsPublicModuleMember(modules, declaration)`
`67`	`67`	`\|\| IsClassLifeCycleHandler(enumerable, declaration)`