Fix evaluation whether a default member has non-optional parameters in ObjectVariableNotSetInspection

Moreover, introduces more tests around default members (partially failing) and removes or alters tests that tested wrong behaviour.

Author: MDoerner

Rubberduck.CodeAnalysis/Inspections/Concrete/VariableRequiresSetAssignmentEvaluator.cs

@@ -59,7 +59,7 @@ public static bool RequiresSetAssignment(IdentifierReference reference, IDeclara
                 }
                 var parameters = (classModule.DefaultMember as IParameterizedDeclaration)?.Parameters;
                 // assign declaration is an object without a default parameterless (or with all parameters optional) member - LHS needs a 'Set' keyword.
-                return parameters != null && parameters.All(p => p.IsOptional);
+                return parameters != null && parameters.Any(p => !p.IsOptional);
             }
 
             // assigned declaration is a variant. we need to know about the RHS of the assignment.           

RubberduckTests/Inspections/ObjectVariableNotSetInspectionTests.cs

@@ -155,19 +155,6 @@ Private Sub TestSub(ByRef testParam As Variant)
             AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount, "VBA.4.2.xml");
         }
 
-        [Test]
-        [Category("Inspections")]
-        public void ObjectVariableNotSet_GivenVariantVariableAssignedDeclaredRange_ReturnsResult()
-        {
-            var expectResultCount = 1;
-            var input =
-@"
-Private Sub TestSub(ByRef testParam As Variant, target As Range)
-    testParam = target
-End Sub";
-            AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount, "Excel.1.8.xml");
-        }
-
         [Test]
         [Category("Inspections")]
         public void ObjectVariableNotSet_GivenVariantVariableAssignedBaseType_ReturnsNoResult()
@@ -182,24 +169,6 @@ Dim target As Variant
             AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount);
         }
 
-        [Test]
-        [Category("Inspections")]
-        public void ObjectVariableNotSet_GivenObjectVariableNotSet_ReturnsResult()
-        {
-            var expectResultCount = 1;
-            var input =
-@"
-Private Sub Workbook_Open()
-    
-    Dim target As Range
-    target = Range(""A1"")
-    
-    target.Value = ""forgot something?""
-
-End Sub";
-            AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount, "Excel.1.8.xml");
-        }
-
         [Test]
         [Category("Inspections")]
         public void ObjectVariableNotSet_GivenObjectVariableNotSet_Ignored_DoesNotReturnResult()
@@ -490,7 +459,7 @@ Dim bar As Collection
 
         [Test]
         [Category("Inspections")]
-        public void ObjectVariableNotSet_SinlgeRHSVariableCaseRespectsDeclarationShadowing()
+        public void ObjectVariableNotSet_SingleRHSVariableCaseRespectsDeclarationShadowing()
         {
 
             var expectResultCount = 0;
@@ -507,6 +476,82 @@ Dim bar As Long
             AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount);
         }
 
+        [Test]
+        [Category("Inspections")]
+        public void ObjectVariableNotSet_SingleRHSVariableCaseRespectsDefaultMembers()
+        {
+            var expectResultCount = 0;
+            var input =
+                @"
+Private Sub Test()    
+    Dim foo As Range
+    Dim bar As Variant    
+    bar = foo
+End Sub";
+            AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount, "Excel.1.8.xml");
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ObjectVariableNotSet_SingleRHSVariableCaseIdentifiesDefaultMembersNotReturningAnObject()
+        {
+            var expectResultCount = 1;
+            var input =
+                @"
+Private Sub Test()    
+    Dim foo As Recordset
+    Dim bar As Variant    
+    bar = foo
+End Sub";
+            //The default member of Recordset is Fields, which is an object.
+            AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount, "ADODB.6.1");
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ObjectVariableNotSet_AssignmentToVarirableWithDefaultMemberReturningAnObject_OneResult()
+        {
+            var expectResultCount = 1;
+            var input =
+                @"
+Private Sub Test()    
+    Dim foo As Recordset
+    Dim bar As Variant    
+    foo = bar
+End Sub";
+            //The default member of Recordset is Fields, which is an object.
+            AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount, "ADODB.6.1");
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ObjectVariableNotSet_NewExprWithNonObjectDefaultMember_NoResult()
+        {
+            var expectResultCount = 0;
+            var input =
+                @"
+Private Sub Test()    
+    Dim foo As Variant  
+    foo = New Connection
+End Sub";
+            AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount, "ADODB.6.1");
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ObjectVariableNotSet_NewExprWithObjectOnlyDefaultMember_OneResult()
+        {
+            var expectResultCount = 1;
+            var input =
+                @"
+Private Sub Test()    
+    Dim foo As Variant  
+    foo = New Recordset
+End Sub";
+            //The default member of Recordset is Fields, which is an object.
+            AssertInputCodeYieldsExpectedInspectionResultCount(input, expectResultCount, "ADODB.6.1");
+        }
+
         [Test]
         [Category("Inspections")]
         public void ObjectVariableNotSet_LSetOnUDT_ReturnsNoResult()

RubberduckTests/QuickFixes/UseSetKeywordForObjectAssignmentQuickFixTests.cs

@@ -62,21 +62,13 @@ public void ObjectVariableNotSet_ForFunctionAssignment_ReturnsResult()
         {
             var inputCode =
                 @"
-Private Function CombineRanges(ByVal source As Range, ByVal toCombine As Range) As Range
-    If source Is Nothing Then
-        CombineRanges = toCombine 'no inspection result (but there should be one!)
-    Else
-        CombineRanges = Union(source, toCombine) 'no inspection result (but there should be one!)
-    End If
+Private Function ReturnObject(ByVal source As Object) As Object
+    ReturnObject = source
 End Function";
             var expectedCode =
                 @"
-Private Function CombineRanges(ByVal source As Range, ByVal toCombine As Range) As Range
-    If source Is Nothing Then
-        Set CombineRanges = toCombine 'no inspection result (but there should be one!)
-    Else
-        Set CombineRanges = Union(source, toCombine) 'no inspection result (but there should be one!)
-    End If
+Private Function ReturnObject(ByVal source As Object) As Object
+    Set ReturnObject = source
 End Function";
 
             var actualCode = ApplyQuickFixToAllInspectionResults(inputCode, state => new ObjectVariableNotSetInspection(state));