Skip to content

Commit 2865aac

Browse files
committed
Catch crashes in commands.
1 parent debaf1e commit 2865aac

File tree

59 files changed

+145
-118
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+145
-118
lines changed

RetailCoder.VBE/Root/FatalExceptionInterceptor.cs

Lines changed: 0 additions & 20 deletions
This file was deleted.

RetailCoder.VBE/Root/RubberduckModule.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -326,8 +326,6 @@ private void BindCommandsToMenuItems()
326326

327327
binding.When(request => whenCommandMenuItemCondition(request) || whenHooksCondition(request))
328328
.InSingletonScope();
329-
330-
binding.Intercept().With<FatalExceptionInterceptor>();
331329
}
332330
}
333331
catch (InvalidOperationException)

RetailCoder.VBE/Rubberduck.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,6 @@
391391
<Compile Include="Refactorings\ExtractMethod\IExtractMethodProc.cs" />
392392
<Compile Include="Refactorings\ExtractMethod\IExtractMethodRule.cs" />
393393
<Compile Include="Refactorings\ExtractMethod\IExtractMethodSelectionValidation.cs" />
394-
<Compile Include="Root\FatalExceptionInterceptor.cs" />
395394
<Compile Include="Root\EnumerableCounterInterceptor.cs" />
396395
<Compile Include="Root\InterceptedException.cs" />
397396
<Compile Include="Root\InterceptorBase.cs" />

RetailCoder.VBE/UI/CodeExplorer/Commands/CodeExplorer_AddClassModuleCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ public CodeExplorer_AddClassModuleCommand(VBE vbe)
1414
_vbe = vbe;
1515
}
1616

17-
public override bool CanExecute(object parameter)
17+
public override bool CanExecuteImpl(object parameter)
1818
{
1919
return GetDeclaration(parameter) != null || _vbe.VBProjects.Count == 1;
2020
}
2121

22-
public override void Execute(object parameter)
22+
public override void ExecuteImpl(object parameter)
2323
{
2424
if (parameter != null)
2525
{

RetailCoder.VBE/UI/CodeExplorer/Commands/CodeExplorer_AddStdModuleCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ public CodeExplorer_AddStdModuleCommand(VBE vbe)
1414
_vbe = vbe;
1515
}
1616

17-
public override bool CanExecute(object parameter)
17+
public override bool CanExecuteImpl(object parameter)
1818
{
1919
return GetDeclaration(parameter) != null || _vbe.VBProjects.Count == 1;
2020
}
2121

22-
public override void Execute(object parameter)
22+
public override void ExecuteImpl(object parameter)
2323
{
2424
if (parameter != null)
2525
{

RetailCoder.VBE/UI/CodeExplorer/Commands/CodeExplorer_AddTestModuleCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ public CodeExplorer_AddTestModuleCommand(VBE vbe, NewUnitTestModuleCommand newUn
1717
_newUnitTestModuleCommand = newUnitTestModuleCommand;
1818
}
1919

20-
public override bool CanExecute(object parameter)
20+
public override bool CanExecuteImpl(object parameter)
2121
{
2222
return GetDeclaration(parameter) != null || _vbe.VBProjects.Count == 1;
2323
}
2424

25-
public override void Execute(object parameter)
25+
public override void ExecuteImpl(object parameter)
2626
{
2727
if (parameter != null)
2828
{

RetailCoder.VBE/UI/CodeExplorer/Commands/CodeExplorer_AddUserFormCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ public CodeExplorer_AddUserFormCommand(VBE vbe)
1414
_vbe = vbe;
1515
}
1616

17-
public override bool CanExecute(object parameter)
17+
public override bool CanExecuteImpl(object parameter)
1818
{
1919
return GetDeclaration(parameter) != null || _vbe.VBProjects.Count == 1;
2020
}
2121

22-
public override void Execute(object parameter)
22+
public override void ExecuteImpl(object parameter)
2323
{
2424
if (parameter != null)
2525
{

RetailCoder.VBE/UI/CodeExplorer/Commands/CodeExplorer_CommitCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ public CodeExplorer_CommitCommand(SourceControlDockablePresenter presenter)
1313
_presenter = presenter;
1414
}
1515

16-
public override bool CanExecute(object parameter)
16+
public override bool CanExecuteImpl(object parameter)
1717
{
1818
return parameter is CodeExplorerComponentViewModel;
1919
}
2020

21-
public override void Execute(object parameter)
21+
public override void ExecuteImpl(object parameter)
2222
{
2323
_presenter.Show();
2424

RetailCoder.VBE/UI/CodeExplorer/Commands/CodeExplorer_CopyResultsCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public CodeExplorer_CopyResultsCommand(RubberduckParserState state)
1919
_clipboard = new ClipboardWriter();
2020
}
2121

22-
public override void Execute(object parameter)
22+
public override void ExecuteImpl(object parameter)
2323
{
2424
const string XML_SPREADSHEET_DATA_FORMAT = "XML Spreadsheet";
2525

RetailCoder.VBE/UI/CodeExplorer/Commands/CodeExplorer_ExportCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public CodeExplorer_ExportCommand(ISaveFileDialog saveFileDialog)
2525
_saveFileDialog.OverwritePrompt = true;
2626
}
2727

28-
public override bool CanExecute(object parameter)
28+
public override bool CanExecuteImpl(object parameter)
2929
{
3030
if (!(parameter is CodeExplorerComponentViewModel))
3131
{
@@ -37,7 +37,7 @@ public override bool CanExecute(object parameter)
3737
return _exportableFileExtensions.Select(s => s.Key).Contains(componentType);
3838
}
3939

40-
public override void Execute(object parameter)
40+
public override void ExecuteImpl(object parameter)
4141
{
4242
var node = (CodeExplorerComponentViewModel)parameter;
4343
var component = node.Declaration.QualifiedName.QualifiedModuleName.Component;

0 commit comments

Comments
 (0)