fixed results sorting issue

Author: retailcoder

RetailCoder.VBE/Inspections/CodeInspectionResultBase.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Linq;
 using Antlr4.Runtime;
 using Rubberduck.Parsing;
@@ -82,6 +83,11 @@ public QualifiedSelection QualifiedSelection
 
         public virtual CodeInspectionQuickFix DefaultQuickFix { get { return QuickFixes.FirstOrDefault(); } }
 
+        public int CompareTo(ICodeInspectionResult other)
+        {
+            return Inspection.CompareTo(other.Inspection);
+        }
+
         public override string ToString()
         {
             var module = QualifiedSelection.QualifiedName;
@@ -94,6 +100,11 @@ public override string ToString()
                 QualifiedSelection.Selection.StartLine);
         }
 
+        public int CompareTo(object obj)
+        {
+            return CompareTo(obj as ICodeInspectionResult);
+        }
+
         public string ToCsvString()
         {
             var module = QualifiedSelection.QualifiedName;

RetailCoder.VBE/Inspections/ICodeInspectionResult.cs

@@ -5,7 +5,7 @@
 
 namespace Rubberduck.Inspections
 {
-    public interface ICodeInspectionResult
+    public interface ICodeInspectionResult : IComparable<ICodeInspectionResult>, IComparable
     {
         IEnumerable<CodeInspectionQuickFix> QuickFixes { get; }
         CodeInspectionQuickFix DefaultQuickFix { get; }

RetailCoder.VBE/Inspections/IInspection.cs

@@ -1,11 +1,12 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 
 namespace Rubberduck.Inspections
 {
     /// <summary>
     /// An interface that abstracts a runnable code inspection.
     /// </summary>
-    public interface IInspection : IInspectionModel
+    public interface IInspection : IInspectionModel, IComparable<IInspection>, IComparable
     {
         /// <summary>
         /// Runs code inspection on specified parse trees.

RetailCoder.VBE/Inspections/InspectionBase.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Rubberduck.Parsing.Symbols;
@@ -20,6 +21,7 @@ protected InspectionBase(RubberduckParserState state)
         public virtual string Name { get { return GetType().Name; } }
         public virtual CodeInspectionSeverity Severity { get; set; }
         public virtual string Meta { get { return InspectionsUI.ResourceManager.GetString(Name + "Meta"); } }
+        // ReSharper disable once UnusedMember.Global: it's referenced in xaml
         public virtual string InspectionTypeName { get { return InspectionsUI.ResourceManager.GetString(InspectionType.ToString()); } }
         public virtual string AnnotationName { get { return Name.Replace("Inspection", string.Empty); } }
 
@@ -32,5 +34,15 @@ protected virtual IEnumerable<Declaration> UserDeclarations
         {
             get { return State.AllUserDeclarations.Where(declaration => !declaration.IsInspectionDisabled(AnnotationName)); }
         }
+
+        public int CompareTo(IInspection other)
+        {
+            return string.Compare(InspectionType + Name, other.InspectionType + other.Name, StringComparison.Ordinal);
+        }
+
+        public int CompareTo(object obj)
+        {
+            return CompareTo(obj as IInspection);
+        }
     }
 }

RetailCoder.VBE/UI/CodeInspections/InspectionResultsControl.xaml

@@ -7,6 +7,7 @@
              xmlns:resx="clr-namespace:Rubberduck.UI"
              xmlns:i="http://schemas.microsoft.com/expression/2010/interactivity"
              xmlns:codeInspections="clr-namespace:Rubberduck.UI.CodeInspections"
+             xmlns:componentModel="clr-namespace:System.ComponentModel;assembly=WindowsBase"
              mc:Ignorable="d" 
              d:DesignHeight="300" d:DesignWidth="300" d:DataContext="{d:DesignInstance codeInspections:InspectionResultsViewModel}">
     <UserControl.Resources>
@@ -92,13 +93,19 @@
                 <PropertyGroupDescription PropertyName="Inspection.InspectionTypeName" />
                 <PropertyGroupDescription PropertyName="Inspection" />
             </CollectionViewSource.GroupDescriptions>
+            <CollectionViewSource.SortDescriptions>
+                <componentModel:SortDescription PropertyName="Inspection" />
+            </CollectionViewSource.SortDescriptions>
         </CollectionViewSource>
 
         <CollectionViewSource x:Key="CodeModuleGroupViewSource" Source="{Binding Results}">
             <CollectionViewSource.GroupDescriptions>
                 <PropertyGroupDescription PropertyName="QualifiedSelection.QualifiedName" />
                 <PropertyGroupDescription PropertyName="Inspection" />
             </CollectionViewSource.GroupDescriptions>
+            <CollectionViewSource.SortDescriptions>
+                <componentModel:SortDescription PropertyName="Inspection" />
+            </CollectionViewSource.SortDescriptions>
         </CollectionViewSource>
 
         <DataTemplate x:Key="InspectionResultTemplate"