Merge pull request #1110 from Hosch250/BugBlipper

Rename inspection meta to get it to show

Author: Hosch250

RetailCoder.VBE/Inspections/InspectionsUI.Designer.cs

@@ -309,7 +309,7 @@
   <data name="UntypedFunctionUsageInspectionName" xml:space="preserve">
     <value>Use of variant-returning string function</value>
   </data>
-  <data name="ProcedureCanBeFunctionInspectionResultFormat" xml:space="preserve">
+  <data name="ProcedureCanBeWrittenAsFunctionInspectionResultFormat" xml:space="preserve">
     <value>Procedure '{0}' can be written as a function.</value>
     <comment>{0} Procedure name</comment>
   </data>
@@ -349,10 +349,10 @@
   <data name="WriteOnlyPropertyInspectionName" xml:space="preserve">
     <value>Write-only property</value>
   </data>
-  <data name="ProcedureCanBeFunctionInspectionMeta" xml:space="preserve">
+  <data name="ProcedureCanBeWrittenAsFunctionInspectionMeta" xml:space="preserve">
     <value>A procedure that only has one parameter passed by reference that is assigned a new value/reference before the procedure exits, is using a ByRef parameter as a return value: consider making it a function instead.</value>
   </data>
-  <data name="ProcedureCanBeFunctionInspectionName" xml:space="preserve">
+  <data name="ProcedureCanBeWrittenAsFunctionInspectionName" xml:space="preserve">
     <value>Procedure can be written as a function</value>
   </data>
   <data name="WriteOnlyPropertyInspectionResultFormat" xml:space="preserve">

RetailCoder.VBE/Inspections/InspectionsUI.resx

@@ -15,8 +15,8 @@ public ProcedureCanBeWrittenAsFunctionInspection(RubberduckParserState state)
         {
         }
 
-        public override string Meta { get { return InspectionsUI.ProcedureCanBeFunctionInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.ProcedureCanBeFunctionInspectionResultFormat; } }
+        public override string Meta { get { return InspectionsUI.ProcedureCanBeWrittenAsFunctionInspectionMeta; } }
+        public override string Description { get { return InspectionsUI.ProcedureCanBeWrittenAsFunctionInspectionResultFormat; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.LanguageOpportunities; } }
 
         public override IEnumerable<InspectionResultBase> GetInspectionResults()

RetailCoder.VBE/Inspections/ProcedureCanBeWrittenAsFunctionInspection.cs

@@ -27,7 +27,7 @@ public ProcedureShouldBeFunctionInspectionResult(IInspection inspection, Rubberd
 
         public override string Description
         {
-            get { return string.Format(InspectionsUI.ProcedureShouldBeFunctionInspectionResultFormat); }
+            get { return InspectionsUI.ProcedureCanBeWrittenAsFunctionInspectionResultFormat; }
         }
     }