Disable buttons appropriately

Author: Hosch250

RetailCoder.VBE/Rubberduck.csproj

@@ -482,6 +482,8 @@
       <DependentUpon>RemoveParametersView.xaml</DependentUpon>
     </Compile>
     <Compile Include="UI\Refactorings\RemoveParameters\RemoveParametersViewModel.cs" />
+    <Compile Include="UI\Refactorings\ReorderParameters\IndexIsNotLastConverter.cs" />
+    <Compile Include="UI\Refactorings\ReorderParameters\IndexIsNotZeroConverter.cs" />
     <Compile Include="UI\Refactorings\ReorderParameters\ReorderParametersView.xaml.cs">
       <DependentUpon>ReorderParametersView.xaml</DependentUpon>
     </Compile>

RetailCoder.VBE/UI/Command/Refactorings/RefactorReorderParametersCommand.cs

@@ -1,4 +1,5 @@
-using System.Collections.ObjectModel;
+using System.Collections.Generic;
+using System.Collections.ObjectModel;
 using System.Linq;
 using System.Runtime.InteropServices;
 using Rubberduck.Common;
@@ -76,9 +77,8 @@ protected override void ExecuteImpl(object parameter)
                     var refactoring = new ReorderParametersRefactoring(Vbe, factory, _msgbox);
                     refactoring.Refactor(selection);*/
                     view.ViewModel.Parameters =
-                        new ObservableCollection<Rubberduck.Refactorings.ReorderParameters.Parameter>(
-                            _state.AllUserDeclarations.Where(s => s.DeclarationType == DeclarationType.Parameter)
-                                .Select((s, i) => new Parameter((ParameterDeclaration)s, i)));
+                        new ObservableCollection<Parameter>(_state.AllUserDeclarations.Where(s => s.DeclarationType == DeclarationType.Parameter)
+                                .Select((s, i) => new Parameter((ParameterDeclaration)s, i)).ToList());
                     view.ShowDialog();
                 }
             }

RetailCoder.VBE/UI/Refactorings/ReorderParameters/IndexIsNotLastConverter.cs

@@ -0,0 +1,21 @@
+using System;
+using System.Globalization;
+using System.Windows.Data;
+
+namespace Rubberduck.UI.Refactorings.ReorderParameters
+{
+    public class IndexIsNotLastConverter : IMultiValueConverter
+    {
+        public object Convert(object[] values, Type targetType, object parameter, CultureInfo culture)
+        {
+            var selectedIndex = (int)values[0];
+            var indexCount = (int)values[1] - 1;
+            return selectedIndex < indexCount;
+        }
+
+        public object[] ConvertBack(object value, Type[] targetTypes, object parameter, CultureInfo culture)
+        {
+            throw new NotImplementedException();
+        }
+    }
+}

RetailCoder.VBE/UI/Refactorings/ReorderParameters/IndexIsNotZeroConverter.cs

@@ -0,0 +1,19 @@
+using System;
+using System.Globalization;
+using System.Windows.Data;
+
+namespace Rubberduck.UI.Refactorings.ReorderParameters
+{
+    public class IndexIsNotZeroConverter : IValueConverter
+    {
+        public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+        {
+            return (int)value != 0;
+        }
+
+        public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+        {
+            throw new NotImplementedException();
+        }
+    }
+}

RetailCoder.VBE/UI/Refactorings/ReorderParameters/ReorderParametersView.xaml

@@ -3,13 +3,13 @@
              xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
              xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
              xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
-             xmlns:removeParameters="clr-namespace:Rubberduck.UI.Refactorings.RemoveParameters"
-             xmlns:converters="clr-namespace:Rubberduck.UI.Converters"
              xmlns:controls="clr-namespace:Rubberduck.UI.Controls"
+             xmlns:reorderParameters="clr-namespace:Rubberduck.UI.Refactorings.ReorderParameters"
              mc:Ignorable="d"
              d:DesignHeight="300" d:DesignWidth="300">
     <UserControl.Resources>
-        <converters:InvertBoolValueConverter x:Key="InvertedBool" />
+        <reorderParameters:IndexIsNotZeroConverter x:Key="IndexIsNotZero" />
+        <reorderParameters:IndexIsNotLastConverter x:Key="IndexIsNotLast" />
     </UserControl.Resources>
     <Grid>
         <Grid.RowDefinitions>
@@ -66,6 +66,7 @@
                         Margin="5,5,5,0"
                         Padding="5,0"
                         HorizontalContentAlignment="Left"
+                        IsEnabled="{Binding ElementName=ParameterGrid, Path=SelectedIndex, Converter={StaticResource IndexIsNotZero}}"
                         Command="{Binding MoveParameterUpCommand}"
                         CommandParameter="{Binding ElementName=ParameterGrid, Path=SelectedItem}">
                     <StackPanel Orientation="Horizontal">
@@ -78,8 +79,20 @@
                         Margin="5,5,5,0"
                         Padding="5,0"
                         HorizontalContentAlignment="Left"
-                        Command="{Binding MoveParameterDown}"
+                        Command="{Binding MoveParameterDownCommand}"
                         CommandParameter="{Binding ElementName=ParameterGrid, Path=SelectedItem}">
+                    <Button.Style>
+                        <Style TargetType="Button">
+                            <Setter Property="IsEnabled">
+                                <Setter.Value>
+                                    <MultiBinding Converter="{StaticResource IndexIsNotLast}">
+                                        <Binding ElementName="ParameterGrid" Path="SelectedIndex" />
+                                        <Binding Path="Parameters.Count" />
+                                    </MultiBinding>
+                                </Setter.Value>
+                            </Setter>
+                        </Style>
+                    </Button.Style>
                     <StackPanel Orientation="Horizontal">
                         <Image Height="10" Source="../../../Resources/arrow-return-180-left.png" Margin="0,0,5,0" />
                         <TextBlock Text="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=ReorderParamsDialog_MoveDownButtonText}" />

RetailCoder.VBE/UI/Refactorings/ReorderParameters/ReorderParametersViewModel.cs

@@ -52,6 +52,8 @@ private void MoveParameterUp(Parameter parameter)
             {
                 var currentIndex = Parameters.IndexOf(parameter);
                 Parameters.Move(currentIndex, currentIndex - 1);
+
+                OnPropertyChanged(nameof(Parameters));
                 OnPropertyChanged(nameof(SignaturePreview));
             }
         }
@@ -62,6 +64,8 @@ private void MoveParameterDown(Parameter parameter)
             {
                 var currentIndex = Parameters.IndexOf(parameter);
                 Parameters.Move(currentIndex, currentIndex + 1);
+
+                OnPropertyChanged(nameof(Parameters));
                 OnPropertyChanged(nameof(SignaturePreview));
             }
         }