fix documents/forms not marked as default instance variables (#1570)

Author: Andrin Meier

Rubberduck.Parsing/Symbols/ClassModuleDeclaration.cs

@@ -10,6 +10,7 @@ public sealed class ClassModuleDeclaration : Declaration
     {
         private readonly bool _isExposed;
         private readonly bool _isGlobalClassModule;
+        private readonly bool _hasDefaultInstanceVariable;
         private readonly List<string> _supertypeNames;
         private readonly HashSet<Declaration> _supertypes;
         private readonly HashSet<Declaration> _subtypes;
@@ -22,7 +23,8 @@ public ClassModuleDeclaration(
                   IEnumerable<IAnnotation> annotations,
                   Attributes attributes,
                   bool isExposed = false,
-                  bool isGlobalClassModule = false)
+                  bool isGlobalClassModule = false,
+                  bool hasDefaultInstanceVariable = false)
             : base(
                   qualifiedName,
                   projectDeclaration,
@@ -43,6 +45,7 @@ public ClassModuleDeclaration(
         {
             _isExposed = isExposed;
             _isGlobalClassModule = isGlobalClassModule;
+            _hasDefaultInstanceVariable = hasDefaultInstanceVariable;
             _supertypeNames = new List<string>();
             _supertypes = new HashSet<Declaration>();
             _subtypes = new HashSet<Declaration>();
@@ -97,12 +100,13 @@ public bool HasPredeclaredId
         {
             get
             {
+                bool attributeHasDefaultInstanceVariable = false;
                 IEnumerable<string> value;
                 if (Attributes.TryGetValue("VB_PredeclaredId", out value))
                 {
-                    return value.Single() == "True";
+                    attributeHasDefaultInstanceVariable = value.Single() == "True";
                 }
-                return false;
+                return _hasDefaultInstanceVariable || attributeHasDefaultInstanceVariable;
             }
         }
 

Rubberduck.Parsing/Symbols/DeclarationSymbolsListener.cs

@@ -68,13 +68,15 @@ public DeclarationSymbolsListener(
             }
             else
             {
+                bool hasDefaultInstanceVariable = type != vbext_ComponentType.vbext_ct_ClassModule && type != vbext_ComponentType.vbext_ct_StdModule;
                 _moduleDeclaration = new ClassModuleDeclaration(
                     _qualifiedName.QualifyMemberName(_qualifiedName.Component.Name),
                     _projectDeclaration,
                     _qualifiedName.Component.Name,
                     false,
                     FindAnnotations(),
-                    moduleAttributes);
+                    moduleAttributes,
+                    hasDefaultInstanceVariable: hasDefaultInstanceVariable);
             }
 
             SetCurrentScope();