fixed magic strings

Author: retailcoder

RetailCoder.VBE/Inspections/ImplicitActiveSheetReferenceInspection.cs

@@ -38,8 +38,9 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
             }
 
             var matches = BuiltInDeclarations.Where(item =>
+                        item.ProjectName == "Excel" &&
                         Targets.Contains(item.IdentifierName) &&
-                        item.ParentScope == "EXCEL.EXE;Excel._Global" &&
+                        item.ParentDeclaration.ComponentName == "Global" &&
                         item.AsTypeName == "Range").ToList();
 
             var issues = matches.Where(item => item.References.Any())

RetailCoder.VBE/Inspections/ImplicitActiveWorkbookReferenceInspection.cs

@@ -4,20 +4,14 @@
 using Rubberduck.Inspections.Resources;
 using Rubberduck.Inspections.Results;
 using Rubberduck.Parsing.VBA;
-using Rubberduck.VBEditor.Application;
-using Rubberduck.VBEditor.Extensions;
-using Rubberduck.VBEditor.SafeComWrappers.Abstract;
 
 namespace Rubberduck.Inspections
 {
     public sealed class ImplicitActiveWorkbookReferenceInspection : InspectionBase
     {
-        private readonly IHostApplication _hostApp;
-
-        public ImplicitActiveWorkbookReferenceInspection(IVBE vbe, RubberduckParserState state)
+        public ImplicitActiveWorkbookReferenceInspection(RubberduckParserState state)
             : base(state)
         {
-            _hostApp = vbe.HostApplication();
         }
 
         public override string Meta { get { return InspectionsUI.ImplicitActiveWorkbookReferenceInspectionMeta; } }
@@ -31,22 +25,16 @@ public ImplicitActiveWorkbookReferenceInspection(IVBE vbe, RubberduckParserState
 
         private static readonly string[] ParentScopes =
         {
-            "EXCEL.EXE;Excel._Global",
-            "EXCEL.EXE;Excel._Application",
-            "EXCEL.EXE;Excel.Sheets",
-            //"EXCEL.EXE;Excel.Worksheets",
+            "_Global",
+            "_Application",
+            "Sheets",
+            //"Worksheets",
         };
 
         public override IEnumerable<InspectionResultBase> GetInspectionResults()
         {
-            if (_hostApp == null || _hostApp.ApplicationName != "Excel")
-            {
-                return Enumerable.Empty<InspectionResultBase>();
-                // if host isn't Excel, the ExcelObjectModel declarations shouldn't be loaded anyway.
-            }
-
             var issues = BuiltInDeclarations
-                .Where(item => ParentScopes.Contains(item.ParentScope) 
+                .Where(item => item.ProjectName == "Excel" && ParentScopes.Contains(item.ComponentName) 
                     && item.References.Any(r => Targets.Contains(r.IdentifierName)))
                 .SelectMany(declaration => declaration.References.Distinct())
                 .Where(item => Targets.Contains(item.IdentifierName))

Rubberduck.Parsing/VBA/RubberduckParser.cs

@@ -654,7 +654,7 @@ private void ResolveReferences(DeclarationFinder finder, IVBComponent component,
                     var watch = Stopwatch.StartNew();
                     walker.Walk(listener, tree);
                     watch.Stop();
-                    Logger.Debug("Binding Resolution done for component '{0}' in {1}ms (thread {2})", component.Name,
+                    Logger.Debug("Binding resolution done for component '{0}' in {1}ms (thread {2})", component.Name,
                         watch.ElapsedMilliseconds, Thread.CurrentThread.ManagedThreadId);
 
                     State.SetModuleState(component, ParserState.Ready);