Fix incorrect check of IntPtr.Zero and check oInst as the xml-docs said to do...

bclothier · bclothier · commit 222730b5ccae · 2020-09-05T21:27:12.000-05:00
diff --git a/Rubberduck.VBEEditor/ComManagement/TypeLibs/Utility/VarDescExtensions.cs b/Rubberduck.VBEEditor/ComManagement/TypeLibs/Utility/VarDescExtensions.cs
@@ -32,7 +32,7 @@ public static bool IsValidVBAConstant(this VARDESC varDesc)
 
             return (varDesc.memid & _ourConstantsDispatchMemberIDRangeBitmaskCheck) >= _ourConstantsDispatchMemberIDRangeStart
                 && varDesc.varkind == VARKIND.VAR_STATIC 
-                && varDesc.desc.lpvarValue != IntPtr.Zero;
+                && varDesc.desc.oInst != 0;
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public static bool IsValidVBAConstant(this VARDESC varDesc)`
`32`	`32`
`33`	`33`	`return (varDesc.memid & _ourConstantsDispatchMemberIDRangeBitmaskCheck) >= _ourConstantsDispatchMemberIDRangeStart`
`34`	`34`	`&& varDesc.varkind == VARKIND.VAR_STATIC`
`35`		`- && varDesc.desc.lpvarValue != IntPtr.Zero;`
	`35`	`+ && varDesc.desc.oInst != 0;`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`	`}`