Removed use of HashSet and minor edits to PassByRefQuickFix

Author: BZngr

RetailCoder.VBE/Inspections/QuickFixes/AssignedByValParameterMakeLocalCopyQuickFix.cs

@@ -133,12 +133,12 @@ private IEnumerable<string> GetIdentifierNamesAccessibleToProcedureContext()
                         && item.ParentScopeDeclaration is ProceduralModuleDeclaration)))
                 .ToList();
 
-            var accessibleIdentifierNames = new HashSet<string>();
-            accessibleIdentifierNames.UnionWith(allSameProcedureDeclarations.Select(d => d.IdentifierName));
-            accessibleIdentifierNames.UnionWith(sameModuleDeclarations.Select(d => d.IdentifierName));
-            accessibleIdentifierNames.UnionWith(allGloballyAccessibleDeclarations.Select(d => d.IdentifierName));
+            var accessibleIdentifierNames = new List<string>();
+            accessibleIdentifierNames.AddRange(allSameProcedureDeclarations.Select(d => d.IdentifierName));
+            accessibleIdentifierNames.AddRange(sameModuleDeclarations.Select(d => d.IdentifierName));
+            accessibleIdentifierNames.AddRange(allGloballyAccessibleDeclarations.Select(d => d.IdentifierName));
 
-            return accessibleIdentifierNames.ToList();
+            return accessibleIdentifierNames.Distinct();
         }
 
         private bool IsDeclaredInMethodOrProperty(RuleContext context)

RetailCoder.VBE/Inspections/QuickFixes/PassParameterByReferenceQuickFix.cs

@@ -4,6 +4,7 @@
 using Rubberduck.Parsing.Grammar;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.VBEditor;
+using Rubberduck.VBEditor.SafeComWrappers.Abstract;
 
 namespace Rubberduck.Inspections.QuickFixes
 {
@@ -12,18 +13,19 @@ namespace Rubberduck.Inspections.QuickFixes
     /// </summary>
     public class PassParameterByReferenceQuickFix : QuickFixBase
     {
-        private Declaration _target;
+        private readonly ICodeModule _codeModule;
+        private VBAParser.ArgContext _argContext;
 
         public PassParameterByReferenceQuickFix(Declaration target, QualifiedSelection selection)
             : base(target.Context, selection, InspectionsUI.PassParameterByReferenceQuickFix)
         {
-            _target = target;
+            _argContext = target.Context as VBAParser.ArgContext;
+            _codeModule = Selection.QualifiedName.Component.CodeModule;
         }
 
         public override void Fix()
         {
-            var module = Selection.QualifiedName.Component.CodeModule;
-            module.ReplaceToken(((VBAParser.ArgContext)Context).BYVAL().Symbol, Tokens.ByRef);
+            _codeModule.ReplaceToken(_argContext.BYVAL().Symbol, Tokens.ByRef);
         }
     }
 }