Make parser update invalid cache values caused by components being removed while the code is running

Author: Hosch250

Rubberduck.Parsing/VBA/RubberduckParser.cs

@@ -124,7 +124,7 @@ public void Parse()
             // tests do not fire events when components are removed--clear components
             foreach (var tree in State.ParseTrees)
             {
-                State.ClearStateCache(tree.Key.Component);
+                State.ClearStateCache(tree.Key);    // handle potentially removed components without crashing
             }
 
             SyncComReferences(State.Projects);
@@ -205,6 +205,32 @@ private void ParseAll()
                 }
             }
 
+            var componentsRemoved = false;
+            foreach (var declaration in State.AllUserDeclarations)
+            {
+                if (!declaration.DeclarationType.HasFlag(DeclarationType.Module))
+                {
+                    continue;
+                }
+
+                var componentExists = false;
+                foreach (var component in components)
+                {
+                    if (component.Name == declaration.ComponentName &&
+                        component.Collection.Parent.HelpFile == declaration.ProjectId)
+                    {
+                        componentExists = true;
+                        break;
+                    }
+                }
+
+                if (!componentExists)
+                {
+                    componentsRemoved = true;
+                    State.ClearStateCache(declaration.QualifiedName.QualifiedModuleName);
+                }
+            }
+
             var toParse = new List<VBComponent>();
             var unchanged = new List<VBComponent>();
 
@@ -225,6 +251,11 @@ private void ParseAll()
 
             if (toParse.Count == 0)
             {
+                if (componentsRemoved)  // trigger UI updates
+                {
+                    State.SetStatusAndFireStateChanged(ParserState.ResolvedDeclarations);
+                }
+
                 State.SetStatusAndFireStateChanged(State.Status);
                 return;
             }

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -677,6 +677,53 @@ public bool ClearStateCache(VBComponent component, bool notifyStateChanged = fal
             return success;
         }
 
+        public bool ClearStateCache(QualifiedModuleName component, bool notifyStateChanged = false)
+        {
+            var keys = new List<QualifiedModuleName> { component };
+            foreach (var key in _moduleStates.Keys)
+            {
+                if (key.Equals(component) && !keys.Contains(key))
+                {
+                    keys.Add(key);
+                }
+            }
+
+            var success = RemoveKeysFromCollections(keys);
+
+            var projectId = component.ProjectId;
+            var sameProjectDeclarations = new List<KeyValuePair<QualifiedModuleName, ModuleState>>();
+            foreach (var item in _moduleStates)
+            {
+                if (item.Key.ProjectId == projectId)
+                {
+                    sameProjectDeclarations.Add(new KeyValuePair<QualifiedModuleName, ModuleState>(item.Key, item.Value));
+                }
+            }
+
+            var projectCount = 0;
+            foreach (var item in sameProjectDeclarations)
+            {
+                if (item.Value.Declarations == null) { continue; }
+
+                foreach (var declaration in item.Value.Declarations)
+                {
+                    if (declaration.Key.DeclarationType == DeclarationType.Project)
+                    {
+                        projectCount++;
+                        break;
+                    }
+                }
+            }
+
+            if (notifyStateChanged)
+            {
+                OnStateChanged(ParserState.ResolvedDeclarations);   // trigger test explorer and code explorer updates
+                OnStateChanged(ParserState.Ready);   // trigger find all references &c. updates
+            }
+
+            return success;
+        }
+
         public bool RemoveRenamedComponent(VBComponent component, string oldComponentName)
         {
             var match = new QualifiedModuleName(component, oldComponentName);