Stop considering declare statements for EmptyMethodInspection

Author: MDoerner

Rubberduck.CodeAnalysis/Inspections/Concrete/EmptyMethodInspection.cs

@@ -6,8 +6,11 @@
 using System.Collections.Generic;
 using System.Linq;
 using Rubberduck.Parsing.Symbols;
-using Rubberduck.Inspections.Inspections.Extensions;
 using Rubberduck.Common;
+using Rubberduck.Inspections.Inspections.Extensions;
+using Rubberduck.Parsing.VBA.DeclarationCaching;
+using Rubberduck.Parsing.VBA.Extensions;
+using Rubberduck.VBEditor;
 
 namespace Rubberduck.Inspections.Concrete
 {
@@ -39,19 +42,48 @@ public EmptyMethodInspection(RubberduckParserState state)
 
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
-            var allInterfaces = new HashSet<ClassModuleDeclaration>(State.DeclarationFinder.FindAllUserInterfaces());
-
-            return State.DeclarationFinder.UserDeclarations(DeclarationType.Member)
-                .Where(member => !allInterfaces.Any(userInterface => userInterface.QualifiedModuleName == member.QualifiedModuleName)
-                                 && !(member is ModuleBodyElementDeclaration mbe && mbe.Block.ContainsExecutableStatements()))
-
-                .Select(result => new DeclarationInspectionResult(this,
-                                        string.Format(InspectionResults.EmptyMethodInspection,
-                                                    Resources.RubberduckUI.ResourceManager
-                                                        .GetString("DeclarationType_" + result.DeclarationType)
-                                                        .Capitalize(),
-                                                    result.IdentifierName),
-                                        result));
+            var finder = State.DeclarationFinder;
+
+            var userInterfaces = UserInterfaces(finder);
+            var emptyMethods = EmptyNonInterfaceMethods(finder, userInterfaces);
+
+            return emptyMethods.Select(Result);
+        }
+
+        private static ICollection<QualifiedModuleName> UserInterfaces(DeclarationFinder finder)
+        {
+            return finder
+                .FindAllUserInterfaces()
+                .Select(decl => decl.QualifiedModuleName)
+                .ToHashSet();
+        }
+
+        private static IEnumerable<Declaration> EmptyNonInterfaceMethods(DeclarationFinder finder, ICollection<QualifiedModuleName> userInterfaces)
+        {
+            return finder
+                .UserDeclarations(DeclarationType.Member)
+                .Where(member => !userInterfaces.Contains(member.QualifiedModuleName)
+                                 && member is ModuleBodyElementDeclaration moduleBodyElement
+                                 && !moduleBodyElement.Block.ContainsExecutableStatements());
+        }
+
+        private IInspectionResult Result(Declaration member)
+        {
+            return new DeclarationInspectionResult(
+                this,
+                ResultDescription(member),
+                member);
+        }
+
+        private static string ResultDescription(Declaration member)
+        {
+            var identifierName = member.IdentifierName;
+            var declarationType = member.DeclarationType.ToLocalizedString();
+
+            return string.Format(
+                InspectionResults.EmptyMethodInspection,
+                declarationType,
+                identifierName);
         }
     }
 }

RubberduckTests/Inspections/EmptyMethodInspectionTests.cs

@@ -118,6 +118,17 @@ Sub Foo()
             Assert.AreEqual(0, InspectionResultsForStandardModule(inputCode).Count());
         }
 
+        [Test]
+        [Category("Inspections")]
+        public void EmptyMethod_DeclareStatement_NoResult()
+        {
+            string inputCode =
+                $@"
+Private Declare PtrSafe Function GetKeyState Lib ""user32.dll"" (ByVal nVirtKey As Long) As Integer
+";
+            Assert.AreEqual(0, InspectionResultsForStandardModule(inputCode).Count());
+        }
+
         private void CheckActualEmptyBlockCountEqualsExpected(string interfaceCode, string concreteCode, int expectedCount)
         {
             var builder = new MockVbeBuilder();