Make SettingsProvider responsible for settings

This moves the Consumer-Visible interfaces for Settings into the SettingsProvider project.
Additionally a base-implementation for a ConfigurationService is provided.
It uses a clear reflection-based mechanism to load the defaults for a given settings type
from a settings class. The type is provided as a Type-Argument to the constructor.

This structure should allow easily extensible and customizable settings loading with caching and defaults.

Author: Vogel612

Rubberduck.CodeAnalysis/Inspections/Inspector.cs

@@ -40,7 +40,7 @@ public Inspector(IConfigurationService<CodeInspectionSettings> configService, II
 
             private void ConfigServiceSettingsChanged(object sender, EventArgs e)
             {
-                var config = _configService.Load();
+                var config = _configService.Read();
                 UpdateInspectionSeverity(config);
             }
 
@@ -71,7 +71,7 @@ public async Task<IEnumerable<IInspectionResult>> FindIssuesAsync(RubberduckPars
                 var allIssues = new ConcurrentBag<IInspectionResult>();
                 token.ThrowIfCancellationRequested();
 
-                var config = _configService.Load();
+                var config = _configService.Read();
                 UpdateInspectionSeverity(config);
                 token.ThrowIfCancellationRequested();
 

Rubberduck.CodeAnalysis/Settings/CodeInspectionConfigProvider.cs

@@ -10,56 +10,41 @@ namespace Rubberduck.CodeAnalysis.Settings
 {
     public class CodeInspectionConfigProvider : ConfigurationServiceBase<CodeInspectionSettings>
     {
-        private readonly CodeInspectionSettings defaultSettings;
         private readonly HashSet<string> foundInspectionNames;
 
-        public CodeInspectionConfigProvider(IPersistanceService<CodeInspectionSettings> persister, IInspectionProvider inspectionProvider)
-            : base(persister)
+        public CodeInspectionConfigProvider(IPersistenceService<CodeInspectionSettings> persister, IInspectionProvider inspectionProvider)
+            : base(persister, new DefaultSettings<CodeInspectionSettings, Properties.CodeInspectionDefaults>())
         {
             foundInspectionNames = inspectionProvider.Inspections.Select(inspection => inspection.Name).ToHashSet();
-            defaultSettings = new DefaultSettings<CodeInspectionSettings, Properties.CodeInspectionDefaults>().Default;
             // Ignore settings for unknown inspections, for example when using the Experimental attribute
-            defaultSettings.CodeInspections = defaultSettings.CodeInspections.Where(setting => foundInspectionNames.Contains(setting.Name)).ToHashSet();
+            Defaults.Default.CodeInspections = Defaults.Default.CodeInspections.Where(setting => foundInspectionNames.Contains(setting.Name)).ToHashSet();
 
-            var defaultNames = defaultSettings.CodeInspections.Select(x => x.Name);
+            var defaultNames = Defaults.Default.CodeInspections.Select(x => x.Name);
             var nonDefaultInspections = inspectionProvider.Inspections.Where(inspection => !defaultNames.Contains(inspection.Name));
 
-            defaultSettings.CodeInspections.UnionWith(nonDefaultInspections.Select(inspection => new CodeInspectionSetting(inspection)));
+            Defaults.Default.CodeInspections.UnionWith(nonDefaultInspections.Select(inspection => new CodeInspectionSetting(inspection)));
         }
 
-        public override CodeInspectionSettings Load()
+        public override CodeInspectionSettings Read()
         {
-            var loaded = persister.Load(defaultSettings);
-
-            if (loaded == null)
-            {
-                return defaultSettings;
-            }
-
+            var loaded = LoadCacheValue();
             // Loaded settings don't contain defaults, so we need to combine user settings with defaults.
             var settings = new HashSet<CodeInspectionSetting>();
 
             foreach (var loadedSetting in loaded.CodeInspections.Where(inspection => foundInspectionNames.Contains(inspection.Name)))
             {
-                var matchingDefaultSetting = defaultSettings.CodeInspections.FirstOrDefault(inspection => inspection.Equals(loadedSetting));
+                var matchingDefaultSetting = Defaults.Default.CodeInspections.FirstOrDefault(inspection => inspection.Equals(loadedSetting));
                 if (matchingDefaultSetting != null)
                 {
                     loadedSetting.InspectionType = matchingDefaultSetting.InspectionType;
                 }
 
                 settings.Add(loadedSetting);
             }
-
-            settings.UnionWith(defaultSettings.CodeInspections.Where(inspection => !settings.Contains(inspection)));
+            settings.UnionWith(Defaults.Default.CodeInspections.Where(inspection => !settings.Contains(inspection)));
 
             loaded.CodeInspections = settings;
-
             return loaded;
         }
-
-        public override CodeInspectionSettings LoadDefaults()
-        {
-            return defaultSettings;
-        }
     }
 }

Rubberduck.Core/App.cs

@@ -54,7 +54,7 @@ public App(IMessageBox messageBox,
 
         private void _configService_SettingsChanged(object sender, ConfigurationChangedEventArgs e)
         {
-            _config = _configService.Load();
+            _config = _configService.Read();
             _hooks.HookHotkeys();
             UpdateLoggingLevel();
 
@@ -160,7 +160,7 @@ public void Shutdown()
 
         private void ApplyCultureConfig()
         {
-            _config = _configService.Load();
+            _config = _configService.Read();
 
             var currentCulture = Resources.RubberduckUI.Culture;
             try

Rubberduck.Core/AutoComplete/AutoCompleteService.cs

@@ -43,7 +43,7 @@ private void InitializeConfig()
             {
                 if (!_initialized)
                 {
-                    var config = _configService.Load();
+                    var config = _configService.Read();
                     ApplyAutoCompleteSettings(config);
                 }
             }
@@ -86,7 +86,7 @@ private void HandleIntelliSenseChanged(object sender, IntelliSenseEventArgs e)
 
         private void ConfigServiceSettingsChanged(object sender, ConfigurationChangedEventArgs e)
         {
-            var config = _configService.Load();
+            var config = _configService.Read();
             ApplyAutoCompleteSettings(config);
         }
 

Rubberduck.Core/Common/RubberduckHooks.cs

@@ -43,7 +43,7 @@ public void HookHotkeys()
             Detach();
             _hooks.Clear();
 
-            var config = _config.Load();
+            var config = _config.Read();
             var settings = config.UserSettings.HotkeySettings;
 
             foreach (var hotkeySetting in settings.Settings.Where(hotkeySetting => hotkeySetting.IsEnabled))