Skip to content

Commit 1e44229

Browse files
committed
Expose IdentifierReference on IInspectionResult implementation to correctly handle ignores
1 parent 6d072a8 commit 1e44229

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

Rubberduck.CodeAnalysis/Inspections/Extensions/IgnoreRelatedExtensions.cs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Rubberduck.Parsing.Symbols;
66
using Rubberduck.Parsing.VBA.DeclarationCaching;
77
using Rubberduck.VBEditor;
8-
using System;
98
using System.Linq;
109

1110
namespace Rubberduck.Inspections.Inspections.Extensions
@@ -37,12 +36,12 @@ public static bool IsIgnoringInspectionResult(this IInspectionResult result, Dec
3736
{
3837
switch (result)
3938
{
40-
case DeclarationInspectionResult dr:
41-
return dr.Target.IsIgnoringInspectionResultFor(dr.Inspection.AnnotationName);
42-
case IdentifierReferenceInspectionResult irr:
43-
return irr.QualifiedName.IsIgnoringInspectionResultFor(irr.Context.Start.Line, declarationFinder, irr.Inspection.AnnotationName);
44-
case QualifiedContextInspectionResult qcr:
45-
return qcr.QualifiedName.IsIgnoringInspectionResultFor(qcr.Context.Start.Line, declarationFinder, qcr.Inspection.AnnotationName);
39+
case DeclarationInspectionResult declarationResult:
40+
return declarationResult.Target.IsIgnoringInspectionResultFor(declarationResult.Inspection.AnnotationName);
41+
case IdentifierReferenceInspectionResult identifierReferenceResult:
42+
return identifierReferenceResult.Reference.IsIgnoringInspectionResultFor(identifierReferenceResult.Inspection.AnnotationName);
43+
case QualifiedContextInspectionResult qualifiedContextResult:
44+
return qualifiedContextResult.QualifiedName.IsIgnoringInspectionResultFor(qualifiedContextResult.Context.Start.Line, declarationFinder, qualifiedContextResult.Inspection.AnnotationName);
4645
default:
4746
return false;
4847
}

Rubberduck.CodeAnalysis/Inspections/Results/IdentifierReferenceInspectionResult.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ namespace Rubberduck.Inspections.Results
1111
{
1212
public class IdentifierReferenceInspectionResult : InspectionResultBase
1313
{
14+
public IdentifierReference Reference { get; }
15+
1416
public IdentifierReferenceInspectionResult(IInspection inspection, string description, IDeclarationFinderProvider declarationFinderProvider, IdentifierReference reference, dynamic properties = null) :
1517
base(inspection,
1618
description,
@@ -21,6 +23,7 @@ public IdentifierReferenceInspectionResult(IInspection inspection, string descri
2123
GetQualifiedMemberName(declarationFinderProvider, reference),
2224
(object)properties)
2325
{
26+
Reference = reference;
2427
}
2528

2629
private static QualifiedMemberName? GetQualifiedMemberName(IDeclarationFinderProvider declarationFinderProvider, IdentifierReference reference)

0 commit comments

Comments
 (0)