Merge pull request #2590 from comintern/next

Fix IsImplicitByRef flags for built-in parameters.

Author: retailcoder

Rubberduck.Parsing/Symbols/DeclarationLoaders/FormEventDeclarations.cs

@@ -141,6 +141,9 @@ private static ParameterDeclaration UserFormQueryCloseEventCancelParameter(Decla
                 null,
                 string.Empty,
                 false,
+                true,
+                false,
+                false,
                 true);
         }
 
@@ -155,6 +158,9 @@ private static ParameterDeclaration UserFormQueryCloseEventCloseModeParameter(De
                 null,
                 string.Empty,
                 false,
+                true,
+                false,
+                false,
                 true);
         }
 

Rubberduck.Parsing/Symbols/ParameterDeclaration.cs

@@ -40,6 +40,7 @@ public ParameterDeclaration(QualifiedMemberName qualifiedName,
         {
             _isOptional = isOptional;
             _isByRef = isByRef;
+            _isImplicitByRef = false;
             IsParamArray = isParamArray;
         }
 
@@ -56,7 +57,8 @@ public ParameterDeclaration(QualifiedMemberName qualifiedName,
             bool isOptional,
             bool isByRef,
             bool isArray = false, 
-            bool isParamArray = false)
+            bool isParamArray = false,
+            bool isBuiltIn = false)
             : base(
                   qualifiedName, 
                   parentDeclaration, 
@@ -71,7 +73,7 @@ public ParameterDeclaration(QualifiedMemberName qualifiedName,
                   selection,
                   isArray,
                   asTypeContext,
-                  false)
+                  isBuiltIn)
         {
             _isOptional = isOptional;
             _isByRef = isByRef;
@@ -88,12 +90,10 @@ public ParameterDeclaration(ComParameter parameter, Declaration parent, Qualifie
                 null,
                 parameter.IsOptional,
                 parameter.IsByRef,
-                parameter.IsArray)
-        {
-            IsParamArray = parameter.IsParamArray;
-        }
-            
-  
+                parameter.IsArray,
+                parameter.IsParamArray)
+        { }
+             
         public bool IsOptional { get { return _isOptional; } }
         public bool IsByRef { get { return _isByRef; } }
         public bool IsImplicitByRef { get { return _isImplicitByRef; } }