Conflict name elements must be in same project

BZngr · BZngr · commit 1d491551b5d0 · 2019-09-17T15:45:59.000-07:00
Removed unnecessary ".ToList()" calls.
diff --git a/Rubberduck.Parsing/VBA/DeclarationCaching/DeclarationFinder.cs b/Rubberduck.Parsing/VBA/DeclarationCaching/DeclarationFinder.cs
@@ -1302,7 +1302,7 @@ public IEnumerable<Declaration> FindNewDeclarationNameConflicts(string newName,
                 return Enumerable.Empty<Declaration>();
             }
 
-            var identifierMatches = MatchName(newName).ToList();
+
             if (!identifierMatches.Any())
             {
                 return Enumerable.Empty<Declaration>();
@@ -1326,8 +1326,7 @@ public IEnumerable<Declaration> FindNewDeclarationNameConflicts(string newName,
                                 && !UsesScopeResolution(renameTargetRef.Context.Parent)))
                 || idm.DeclarationType.HasFlag(DeclarationType.Variable)
                     && idm.ParentDeclaration.DeclarationType.HasFlag(DeclarationType.Module)
-                    && renameTarget.References.Any(renameTargetRef => renameTargetRef.QualifiedModuleName == idm.ParentDeclaration.QualifiedModuleName))
-                .ToList();
+                    && renameTarget.References.Any(renameTargetRef => renameTargetRef.QualifiedModuleName == idm.ParentDeclaration.QualifiedModuleName));
 
             if (referenceConflicts.Any())
             {

Original file line number	Diff line number	Diff line change
`@@ -1302,7 +1302,7 @@ public IEnumerable<Declaration> FindNewDeclarationNameConflicts(string newName,`
`1302`	`1302`	`return Enumerable.Empty<Declaration>();`
`1303`	`1303`	`}`
`1304`	`1304`
`1305`		`- var identifierMatches = MatchName(newName).ToList();`
	`1305`	`+`
`1306`	`1306`	`if (!identifierMatches.Any())`
`1307`	`1307`	`{`
`1308`	`1308`	`return Enumerable.Empty<Declaration>();`
`@@ -1326,8 +1326,7 @@ public IEnumerable<Declaration> FindNewDeclarationNameConflicts(string newName,`
`1326`	`1326`	`&& !UsesScopeResolution(renameTargetRef.Context.Parent)))`
`1327`	`1327`	`\|\| idm.DeclarationType.HasFlag(DeclarationType.Variable)`
`1328`	`1328`	`&& idm.ParentDeclaration.DeclarationType.HasFlag(DeclarationType.Module)`
`1329`		`- && renameTarget.References.Any(renameTargetRef => renameTargetRef.QualifiedModuleName == idm.ParentDeclaration.QualifiedModuleName))`
`1330`		`- .ToList();`
	`1329`	`+ && renameTarget.References.Any(renameTargetRef => renameTargetRef.QualifiedModuleName == idm.ParentDeclaration.QualifiedModuleName));`
`1331`	`1330`
`1332`	`1331`	`if (referenceConflicts.Any())`
`1333`	`1332`	`{`