Enhance drag and drop to honor the drag and drop setting

It is only enabled if the corresponding general setting is set to true.

Author: MDoerner

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerViewModel.cs

@@ -63,12 +63,15 @@ public CodeExplorerViewModel(
             _state.StateChanged += HandleStateChanged;
             _state.ModuleStateChanged += ParserState_ModuleStateChanged;
 
-            _externalRemoveCommand = removeCommand;
             _generalSettingsProvider = generalSettingsProvider;
+            _generalSettingsProvider.SettingsChanged += GeneralSettingsChanged;
+            RefreshDragAndDropSetting();
+
             _windowSettingsProvider = windowSettingsProvider;
             _uiDispatcher = uiDispatcher;
             _vbe = vbe;
             _templateProvider = templateProvider;
+            _externalRemoveCommand = removeCommand;
             Annotations = annotations.ToList();
 
             CollapseAllSubnodesCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteCollapseNodes, EvaluateCanSwitchNodeState);
@@ -79,6 +82,7 @@ public CodeExplorerViewModel(
                 RemoveCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteRemoveCommand, _externalRemoveCommand.CanExecute);
             }
 
+
             OnPropertyChanged(nameof(Projects));
 
             SyncCodePaneCommand = syncProvider.GetSyncCommand(this);
@@ -489,12 +493,25 @@ private void ExpandToNode(ICodeExplorerNode node)
 
         public Visibility VBAVisibility => _vbe.Kind == VBEKind.Hosted ? Visibility.Visible : Visibility.Collapsed;
 
+        public bool AllowDragAndDrop { get; internal set; }
+
+        private void GeneralSettingsChanged(object sender, ConfigurationChangedEventArgs e)
+        {
+            RefreshDragAndDropSetting();
+        }
+
+        private void RefreshDragAndDropSetting()
+        {
+            AllowDragAndDrop = _generalSettingsProvider.Read().EnableFolderDragAndDrop;
+        }
+
         public void Dispose()
         {
             if (_state != null)
             {
                 _state.StateChanged -= HandleStateChanged;
                 _state.ModuleStateChanged -= ParserState_ModuleStateChanged;
+                _generalSettingsProvider.SettingsChanged -= GeneralSettingsChanged;
             }
         }
     }

Rubberduck.Core/UI/CodeExplorer/CodeExplorerControl.xaml.cs

@@ -56,11 +56,13 @@ private void TreeView_PreviewMouseMove(object sender, MouseEventArgs e)
 
         private void EvaluateDragInitialization(object sender, MouseEventArgs e)
         {
-            if (e.LeftButton != MouseButtonState.Pressed)
+            if (e.LeftButton != MouseButtonState.Pressed
+                || !(DataContext is CodeExplorerViewModel viewModel)
+                || !viewModel.AllowDragAndDrop)
             {
                 return;
             }
-
+            
             var currentPosition = e.GetPosition(null);
             var fromLeftClick = currentPosition - _lastLeftClickPosition;
 

RubberduckTests/CodeExplorer/CodeExplorerViewModelTests.cs

@@ -13,6 +13,8 @@
 using Rubberduck.Parsing.Annotations;
 using Rubberduck.Parsing.UIContext;
 using Rubberduck.Parsing.VBA;
+using Rubberduck.Settings;
+using Rubberduck.SettingsProvider;
 using Rubberduck.UI.Command.ComCommands;
 using RubberduckTests.Mocks;
 using Rubberduck.VBEditor.SafeComWrappers.Abstract;
@@ -2353,11 +2355,14 @@ public void UnparsedSetToTrue_NoProjects()
             var parser = MockParser.Create(vbe.Object, null, MockVbeEvents.CreateMockVbeEvents(vbe));
             var state = parser.State;
             var dispatcher = new Mock<IUiDispatcher>();
+            var generalSettingsProvider = new Mock<IConfigurationService<GeneralSettings>>();
+            var generalSettings = new GeneralSettings();
+            generalSettingsProvider.Setup(m => m.Read()).Returns(generalSettings);
 
             dispatcher.Setup(m => m.Invoke(It.IsAny<Action>())).Callback((Action argument) => argument.Invoke());
             dispatcher.Setup(m => m.StartTask(It.IsAny<Action>(), It.IsAny<TaskCreationOptions>())).Returns((Action argument, TaskCreationOptions options) => Task.Factory.StartNew(argument.Invoke, options));
 
-            var viewModel = new CodeExplorerViewModel(state, null, null, null, dispatcher.Object, vbe.Object, null,
+            var viewModel = new CodeExplorerViewModel(state, null, generalSettingsProvider.Object, null, dispatcher.Object, vbe.Object, null,
                 new CodeExplorerSyncProvider(vbe.Object, state, vbeEvents.Object), new List<IAnnotation>());
 
             parser.Parse(new CancellationTokenSource());