Merge pull request #887 from Hosch250/BugBlipper

Change signature for all methods that implement an interface after pr…

Author: Hosch250

RetailCoder.VBE/Refactorings/IntroduceParameter/IntroduceParameterRefactoring.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Windows.Forms;
 using Antlr4.Runtime.Misc;
 using Microsoft.Vbe.Interop;
 using Rubberduck.Common;
@@ -69,10 +70,34 @@ public void Refactor(Declaration target)
 
         private void PromoteVariable(Declaration target)
         {
+            if (!PromptIfMethodImplementsInterface(target))
+            {
+                return;
+            }
+
             RemoveVariable(target);
             UpdateSignature(target);
         }
 
+        private bool PromptIfMethodImplementsInterface(Declaration targetVariable)
+        {
+            var functionDeclaration = _declarations.FindSelection(targetVariable.QualifiedSelection, ValidDeclarationTypes);
+            var interfaceImplementation = GetInterfaceImplementation(functionDeclaration);
+
+            if (interfaceImplementation == null)
+            {
+                return true;
+            }
+
+            var message = string.Format(RubberduckUI.IntroduceParameter_PromptIfTargetIsInterface,
+                functionDeclaration.IdentifierName, interfaceImplementation.ComponentName,
+                interfaceImplementation.IdentifierName);
+            var introduceParamToInterface = _messageBox.Show(message, RubberduckUI.IntroduceParameter_Caption,
+                MessageBoxButtons.YesNo, MessageBoxIcon.Question);
+
+            return introduceParamToInterface != DialogResult.No;
+        }
+
         private void UpdateSignature(Declaration targetVariable)
         {
             var functionDeclaration = _declarations.FindSelection(targetVariable.QualifiedSelection, ValidDeclarationTypes);
@@ -91,9 +116,20 @@ private void UpdateSignature(Declaration targetVariable)
             }
 
             var interfaceImplementation = GetInterfaceImplementation(functionDeclaration);
-            if (interfaceImplementation != null)
+            if (interfaceImplementation == null)
+            {
+                return;
+            }
+            UpdateSignature(interfaceImplementation, targetVariable);
+
+            var interfaceImplementations = _declarations.FindInterfaceImplementationMembers()
+                                                    .Where(item => item.Project.Equals(interfaceImplementation.Project)
+                                                           && item.IdentifierName == interfaceImplementation.ComponentName + "_" + interfaceImplementation.IdentifierName
+                                                           && !item.Equals(functionDeclaration));
+
+            foreach (var implementation in interfaceImplementations)
             {
-                UpdateSignature(interfaceImplementation, targetVariable);
+                UpdateSignature(implementation, targetVariable);
             }
         }
 

RetailCoder.VBE/UI/RubberduckUI.Designer.cs

@@ -262,7 +262,7 @@
     <value>Remove parameters</value>
   </data>
   <data name="Refactoring_TargetIsInterfaceMemberImplementation" xml:space="preserve">
-    <value>Method '{0}' implements '{1}.{2}'. Change interface signature? (will propagate to all implementations)</value>
+    <value>Method '{0}' implements '{1}.{2}'. Change interface signature? (Will propagate to all implementations.)</value>
     <comment>0: Selected target; 1: Interface name; 2: Interface member name</comment>
   </data>
   <data name="RemoveParamsDialog_RemoveIllegalSetterLetterParameter" xml:space="preserve">
@@ -1281,4 +1281,8 @@ Are you sure you want to proceed with this rename?</value>
   <data name="IntroduceParameter_Caption" xml:space="preserve">
     <value>Rubberduck - Introduce Parameter</value>
   </data>
+  <data name="IntroduceParameter_PromptIfTargetIsInterface" xml:space="preserve">
+    <value>Method '{0}' implements '{1}.{2}'. Change interface signature? (Will propagate to all implementations.)</value>
+    <comment>0: Selected target; 1: Interface name; 2: Interface member name</comment>
+  </data>
 </root>