Switch to extension method for GetIdentifierReferences.

Author: comintern

Rubberduck.CodeAnalysis/Inspections/Concrete/AssignmentNotUsedInspection.cs

@@ -4,7 +4,6 @@
 using Rubberduck.Parsing.VBA;
 using Rubberduck.Inspections.CodePathAnalysis;
 using Rubberduck.Parsing.Symbols;
-using Rubberduck.Inspections.CodePathAnalysis.Nodes;
 using Rubberduck.Inspections.CodePathAnalysis.Extensions;
 using System.Linq;
 using Rubberduck.Inspections.Results;
@@ -29,41 +28,12 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
             {
                 var tree = _walker.GenerateTree(variable.ParentScopeDeclaration.Context, variable);
 
-                nodes.AddRange(GetIdentifierReferences(tree, variable));
+                nodes.AddRange(tree.GetIdentifierReferences());
             }
 
             return nodes
                 .Select(issue => new IdentifierReferenceInspectionResult(this, Description, State, issue))
                 .ToList();
         }
-
-        private List<IdentifierReference> GetIdentifierReferences(INode node, Declaration declaration)
-        {
-            var nodes = new List<IdentifierReference>();
-
-            var blockNodes = node.GetNodes(new[] { typeof(BlockNode) });
-            foreach (var block in blockNodes)
-            {
-                INode lastNode = default;
-                foreach (var flattenedNode in block.GetFlattenedNodes(new[] { typeof(GenericNode), typeof(BlockNode) }))
-                {
-                    if (flattenedNode is AssignmentNode &&
-                        lastNode is AssignmentNode)
-                    {
-                        nodes.Add(lastNode.Reference);
-                    }
-
-                    lastNode = flattenedNode;
-                }
-
-                if (lastNode is AssignmentNode &&
-                    block.Children[0].GetFirstNode(new[] { typeof(GenericNode) }) is DeclarationNode)
-                {
-                    nodes.Add(lastNode.Reference);
-                }
-            }
-
-            return nodes;
-        }
     }
 }