Closes #1196

Author: Hosch250

RetailCoder.VBE/Inspections/UseMeaningfulNameInspection.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Linq;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
@@ -25,10 +26,11 @@ public UseMeaningfulNameInspection(IMessageBox messageBox, RubberduckParserState
         public override IEnumerable<InspectionResultBase> GetInspectionResults()
         {
             var issues = UserDeclarations
-                            .Where(declaration => declaration.DeclarationType != DeclarationType.ModuleOption &&
+                            .Where(declaration => declaration.DeclarationType != DeclarationType.ModuleOption && 
                                                   (declaration.IdentifierName.Length < 3 ||
                                                   char.IsDigit(declaration.IdentifierName.Last()) ||
-                                                  !declaration.IdentifierName.Any(c => new[] {'a', 'e', 'i', 'o', 'u', 'y'}.Contains(c))))
+                                                  !declaration.IdentifierName.Any(c => 
+                                                      "aeiouy".Any(a => string.Compare(a.ToString(), c.ToString(), StringComparison.OrdinalIgnoreCase) == 0))))
                             .Select(issue => new UseMeaningfulNameInspectionResult(this, issue, State, _wrapperFactory, _messageBox))
                             .ToList();
 

RubberduckTests/Inspections/UseMeaningfulNameInspectionTests.cs

@@ -94,7 +94,7 @@ public void UseMeaningfulName_ReturnsResult_NameEndsWithDigit()
         }
 
         [TestMethod]
-        public void UseMeaningfulName_DoesNotReturnsResult_GoodName()
+        public void UseMeaningfulName_DoesNotReturnsResult_GoodName_LowerCaseVowels()
         {
             const string inputCode =
 @"Sub FooBar()
@@ -120,6 +120,33 @@ public void UseMeaningfulName_DoesNotReturnsResult_GoodName()
             Assert.AreEqual(0, inspectionResults.Count());
         }
 
+        [TestMethod]
+        public void UseMeaningfulName_DoesNotReturnsResult_GoodName_UpperCaseVowels()
+        {
+            const string inputCode =
+@"Sub FOOBAR()
+End Sub";
+
+            //Arrange
+            var builder = new MockVbeBuilder();
+            var project = builder.ProjectBuilder("VBAProject", vbext_ProjectProtection.vbext_pp_none)
+                .AddComponent("MyClass", vbext_ComponentType.vbext_ct_ClassModule, inputCode)
+                .Build();
+            var vbe = builder.AddProject(project).Build();
+
+            var mockHost = new Mock<IHostApplication>();
+            mockHost.SetupAllProperties();
+            var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
+
+            parser.Parse();
+            if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
+
+            var inspection = new UseMeaningfulNameInspection(null, parser.State);
+            var inspectionResults = inspection.GetInspectionResults();
+
+            Assert.AreEqual(0, inspectionResults.Count());
+        }
+
         [TestMethod]
         public void UseMeaningfulName_DoesNotReturnsResult_OptionBase()
         {