fixes Declaration.IsObject implementation / edge-case false positives for ObjectReferenceNotSet

Author: retailcoder

Rubberduck.Parsing/Symbols/Declaration.cs

@@ -349,13 +349,24 @@ private static string CorrectlyFormatedDescription(string literalDescription)
         /// </summary>
         public bool IsEnumeratorMember => _attributes.Any(a => a.Name.EndsWith("VB_UserMemId") && a.Values.Contains("-4"));
 
-        public virtual bool IsObject =>
-            AsTypeName == Tokens.Object || (
-                AsTypeDeclaration?.DeclarationType.HasFlag(DeclarationType.ClassModule) ?? 
-                    !AsTypeIsBaseType
-                    && !IsArray
-                    && !DeclarationType.HasFlag(DeclarationType.UserDefinedType)
-                    && !DeclarationType.HasFlag(DeclarationType.Enumeration));
+        public virtual bool IsObject
+        {
+            get
+            {
+                if (AsTypeName == Tokens.Object || 
+                    (AsTypeDeclaration?.DeclarationType.HasFlag(DeclarationType.ClassModule) ?? false))
+                {
+                    return true;
+                }
+                
+                var result = !(AsTypeIsBaseType || 
+                         IsArray || 
+                         DeclarationType.HasFlag(DeclarationType.UserDefinedType) || 
+                         DeclarationType.HasFlag(DeclarationType.Enumeration));
+
+                return result;
+            }
+        }
 
         public void AddReference(
             QualifiedModuleName module,

Rubberduck.Parsing/Symbols/PropertyDeclaration.cs

@@ -44,8 +44,20 @@ protected PropertyDeclaration(
                 attributes)
         { }
 
-        public override bool IsObject =>
-            base.IsObject || (Parameters.OrderBy(p => p.Selection).LastOrDefault()?.IsObject ?? false);
+        public override bool IsObject
+        {
+            get
+            {
+                if (base.IsObject)
+                {
+                    return true;
+                }
+
+                return (DeclarationType == DeclarationType.PropertyLet ||
+                       DeclarationType == DeclarationType.PropertySet) &&
+                       (Parameters.OrderBy(p => p.Selection).LastOrDefault()?.IsObject ?? false);
+            }
+        }
 
         /// <inheritdoc/>
         protected abstract override bool Implements(IInterfaceExposable member);

RubberduckTests/Inspections/ObjectVariableNotSetInspectionTests.cs

@@ -13,12 +13,12 @@ public class ObjectVariableNotSetInspectionTests
     {
         [Test]
         [Category("Inspections")]
-        public void ObjectVariableNotSet_NotResultForBoolean()
+        public void ObjectVariableNotSet_NotResultForNonObjectPropertyGetWithObjectArgument()
         {
             var expectedResultCount = 0;
             var input = @"
-Public Property Get Something() As Boolean
-    Something = True
+Public Property Get Foo(ByVal bar As Object) As Boolean
+    Foo = True
 End Property
 ";
             AssertInputCodeYieldsExpectedInspectionResultCount(input, expectedResultCount);