honor SCP settings; closes #5341

retailcoder · retailcoder · commit 12e00fb5956b · 2020-01-05T12:52:44.000-05:00
diff --git a/Rubberduck.Core/AutoComplete/SelfClosingPairs/SelfClosingPairHandler.cs b/Rubberduck.Core/AutoComplete/SelfClosingPairs/SelfClosingPairHandler.cs
@@ -40,7 +40,7 @@ public SelfClosingPairHandler(ICodePaneHandler pane, SelfClosingPairCompletionSe
         public override bool Handle(AutoCompleteEventArgs e, AutoCompleteSettings settings, out CodeString result)
         {
             result = null;
-            if (!_scpInputLookup.TryGetValue(e.Character, out var pair) && e.Character != '\b')
+            if (!settings.SelfClosingPairs.IsEnabled || !_scpInputLookup.TryGetValue(e.Character, out var pair) && e.Character != '\b')
             {
                 // not an interesting keypress.
                 return false;

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public SelfClosingPairHandler(ICodePaneHandler pane, SelfClosingPairCompletionSe`
`40`	`40`	`public override bool Handle(AutoCompleteEventArgs e, AutoCompleteSettings settings, out CodeString result)`
`41`	`41`	`{`
`42`	`42`	`result = null;`
`43`		`- if (!_scpInputLookup.TryGetValue(e.Character, out var pair) && e.Character != '\b')`
	`43`	`+ if (!settings.SelfClosingPairs.IsEnabled \|\| !_scpInputLookup.TryGetValue(e.Character, out var pair) && e.Character != '\b')`
`44`	`44`	`{`
`45`	`45`	`// not an interesting keypress.`
`46`	`46`	`return false;`