Performance improvements (allocations), comments.

Author: mansellan

Rubberduck.Core/UI/CodeExplorer/Commands/DeleteCommand.cs

@@ -27,7 +27,7 @@ public DeleteCommand(RemoveCommand removeCommand, IProjectsProvider projectsProv
             AddToCanExecuteEvaluation(SpecialEvaluateCanExecute);
         }
 
-        public override IEnumerable<Type> ApplicableNodeTypes => new List<Type> { typeof(CodeExplorerComponentViewModel) };
+        public override IEnumerable<Type> ApplicableNodeTypes { get; } = new List<Type> { typeof(CodeExplorerComponentViewModel) };
 
         private bool SpecialEvaluateCanExecute(object parameter)
         {
@@ -42,14 +42,14 @@ protected override void OnExecute(object parameter)
                 return;
             }
 
-            var qualifiedModuleName = node.Declaration.QualifiedName.QualifiedModuleName;
+            var qualifiedModuleName = node.Declaration.QualifiedModuleName;
             var component = _projectsProvider.Component(qualifiedModuleName);
             if (component is null)
             {
                 return;
             }
 
-            // Permanent operation, prompt for confirm
+            // "{qualifiedModuleName.Name} will be permanently deleted. Continue?" (localized)
             var message = string.Format(Resources.CodeExplorer.CodeExplorerUI.ConfirmBeforeDelete_Prompt, qualifiedModuleName.Name);
             if (!_messageBox.ConfirmYesNo(message, Resources.CodeExplorer.CodeExplorerUI.ConfirmBeforeDelete_Caption))
             {
@@ -89,6 +89,7 @@ protected override void OnExecute(object parameter)
             // Let the user know if there are any component files left on disk
             if (failedDeletions.Any())
             {
+                // "The following files could not be deleted: {fileDeletions}" (localized)
                 message = string.Format(Resources.CodeExplorer.CodeExplorerUI.DeleteFailed_Message, string.Join(Environment.NewLine, failedDeletions));
                 _messageBox.NotifyWarn(message, Resources.CodeExplorer.CodeExplorerUI.DeleteFailed_Caption);
             }

Rubberduck.Core/UI/CodeExplorer/Commands/RemoveCommand.cs

@@ -27,12 +27,13 @@ public RemoveCommand(ExportCommand exportCommand, IProjectsRepository projectsRe
             AddToCanExecuteEvaluation(SpecialEvaluateCanExecute);
         }
 
-        public override IEnumerable<Type> ApplicableNodeTypes => new List<Type> { typeof(CodeExplorerComponentViewModel) };
+        public override IEnumerable<Type> ApplicableNodeTypes { get; } = new List<Type> { typeof(CodeExplorerComponentViewModel)};
 
         private bool SpecialEvaluateCanExecute(object parameter)
         {
             return _exportCommand.CanExecute(parameter) &&
                    parameter is CodeExplorerComponentViewModel viewModel &&
+                   viewModel.Declaration != null &&
                    viewModel.Declaration.QualifiedModuleName.ComponentType != ComponentType.Document;
         }
 

Rubberduck.Resources/CodeExplorer/CodeExplorerUI.Designer.cs

@@ -434,6 +434,6 @@
     <value>Delete Failed</value>
   </data>
   <data name="DeleteFailed_Message" xml:space="preserve">
-    <value>The following files could not be deleted\r\n\r\n{0}</value>
+    <value>The following files could not be deleted:\r\n\r\n{0}</value>
   </data>
 </root>