Merge pull request #4627 from retailcoder/redim

Disable MissingAttributeInspection + edge-case fix for ObjectVariableNotSet

Author: retailcoder

Rubberduck.CodeAnalysis/Inspections/Concrete/MissingAttributeInspection.cs

@@ -8,10 +8,10 @@
 using Rubberduck.Parsing.Grammar;
 using Rubberduck.Parsing.Inspections;
 using Rubberduck.Parsing.Inspections.Abstract;
-using Rubberduck.Resources.Inspections;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
 using Rubberduck.Parsing.VBA.Parsing;
+using Rubberduck.Resources.Inspections;
 
 namespace Rubberduck.Inspections.Concrete
 {
@@ -33,7 +33,7 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
             return Listener.Contexts.Select(context =>
             {
                 var name = string.Format(InspectionResults.MissingAttributeInspection, context.MemberName.MemberName,
-                    ((VBAParser.AnnotationContext) context.Context).annotationName().GetText());
+                    ((VBAParser.AnnotationContext)context.Context).annotationName().GetText());
                 return new QualifiedContextInspectionResult(this, name, context);
             });
         }

Rubberduck.Core/Properties/Settings.Designer.cs

@@ -110,6 +110,13 @@
       <DependentUpon>%(Filename).cs</DependentUpon>
     </EmbeddedResource>
   </ItemGroup>
+  <ItemGroup>
+    <Compile Update="Properties\Settings.Designer.cs">
+      <DesignTime>True</DesignTime>
+      <AutoGen>True</AutoGen>
+      <DependentUpon>Settings.settings</DependentUpon>
+    </Compile>
+  </ItemGroup>
   <!-- END WINDOWS FORMS WORKAROUND SECTION -->
 
 </Project>

Rubberduck.Core/Properties/Settings.settings

@@ -349,13 +349,24 @@ private static string CorrectlyFormatedDescription(string literalDescription)
         /// </summary>
         public bool IsEnumeratorMember => _attributes.Any(a => a.Name.EndsWith("VB_UserMemId") && a.Values.Contains("-4"));
 
-        public virtual bool IsObject =>
-            AsTypeName == Tokens.Object || (
-                AsTypeDeclaration?.DeclarationType.HasFlag(DeclarationType.ClassModule) ?? 
-                    !AsTypeIsBaseType
-                    && !IsArray
-                    && !DeclarationType.HasFlag(DeclarationType.UserDefinedType)
-                    && !DeclarationType.HasFlag(DeclarationType.Enumeration));
+        public virtual bool IsObject
+        {
+            get
+            {
+                if (AsTypeName == Tokens.Object || 
+                    (AsTypeDeclaration?.DeclarationType.HasFlag(DeclarationType.ClassModule) ?? false))
+                {
+                    return true;
+                }
+
+                var isIntrinsic = AsTypeIsBaseType
+                                  || IsArray
+                                  || (AsTypeDeclaration?.DeclarationType.HasFlag(DeclarationType.UserDefinedType) ?? false)
+                                  || (AsTypeDeclaration?.DeclarationType.HasFlag(DeclarationType.Enumeration) ?? false);
+
+                return !isIntrinsic;
+            }
+        }
 
         public void AddReference(
             QualifiedModuleName module,

Rubberduck.Core/Rubberduck.Core.csproj

@@ -44,8 +44,20 @@ protected PropertyDeclaration(
                 attributes)
         { }
 
-        public override bool IsObject =>
-            base.IsObject || (Parameters.OrderBy(p => p.Selection).LastOrDefault()?.IsObject ?? false);
+        public override bool IsObject
+        {
+            get
+            {
+                if (base.IsObject)
+                {
+                    return true;
+                }
+
+                return (DeclarationType == DeclarationType.PropertyLet ||
+                       DeclarationType == DeclarationType.PropertySet) &&
+                       (Parameters.OrderBy(p => p.Selection).LastOrDefault()?.IsObject ?? false);
+            }
+        }
 
         /// <inheritdoc/>
         protected abstract override bool Implements(IInterfaceExposable member);

Rubberduck.Core/app.config

@@ -11,6 +11,19 @@ namespace RubberduckTests.Inspections
     [TestFixture]
     public class ObjectVariableNotSetInspectionTests
     {
+        [Test]
+        [Category("Inspections")]
+        public void ObjectVariableNotSet_NotResultForNonObjectPropertyGetWithObjectArgument()
+        {
+            var expectedResultCount = 0;
+            var input = @"
+Public Property Get Foo(ByVal bar As Object) As Boolean
+    Foo = True
+End Property
+";
+            AssertInputCodeYieldsExpectedInspectionResultCount(input, expectedResultCount);
+        }
+
         [Test]
         [Category("Inspections")]
         public void ObjectVariableNotSet_AlsoAssignedToNothing_ReturnsNoResult()