Skip to content

Commit 0c41340

Browse files
committed
Resolve build errors and cleanup following merge
1 parent 07acbec commit 0c41340

File tree

13 files changed

+22
-374
lines changed

13 files changed

+22
-374
lines changed

Rubberduck.Refactorings/Common/CodeBuilder.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,6 @@ bool TryBuildPropertySetCodeBlock(Declaration prototype,
7070
string content = null,
7171
string parameterIdentifier = null);
7272

73-
/// <summary>
74-
/// Generates a default RHS property parameter IdentifierName
75-
/// </summary>
76-
/// <param name="propertyIdentifier">Let/Set Property IdentifierName</param>
77-
string BuildPropertyRhsParameterName(string propertyIdentifier);
78-
7973
/// <summary>
8074
/// Generates a UserDefinedType (UDT) declaration using a <c>VariableDeclaration</c> as the prototype for
8175
/// creating the UserDefinedTypeMember.

Rubberduck.Refactorings/EncapsulateField/EncapsulateFieldElementsBuilder.cs

Lines changed: 0 additions & 162 deletions
This file was deleted.

Rubberduck.Refactorings/EncapsulateField/EncapsulateFieldInsertNewCode/NewContentAggregator.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ namespace Rubberduck.Refactorings.EncapsulateField
66
{
77
public enum NewContentType
88
{
9-
ImplementsDeclaration,
10-
WithEventsDeclaration,
11-
EnumerationTypeDeclaration,
129
UserDefinedTypeDeclaration,
1310
DeclarationBlock,
1411
CodeSectionBlock,

Rubberduck.Refactorings/EncapsulateField/FieldCandidates/ArrayCandidate.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ public interface IArrayCandidate : IEncapsulateFieldCandidate
1515
public class ArrayCandidate : EncapsulateFieldCandidate, IArrayCandidate
1616
{
1717
private string _subscripts;
18-
public ArrayCandidate(Declaration declaration, Func<string,string> parameterNameBuilder)
19-
:base(declaration, parameterNameBuilder)
18+
public ArrayCandidate(Declaration declaration)
19+
:base(declaration)
2020
{
2121
ImplementLet = false;
2222
ImplementSet = false;

Rubberduck.Refactorings/EncapsulateField/FieldCandidates/EncapsulateFieldCandidate.cs

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using Rubberduck.Refactorings.Common;
55
using Rubberduck.Refactorings.EncapsulateField.Extensions;
66
using Rubberduck.VBEditor;
7-
using System;
87
using System.Collections.Generic;
98

109
namespace Rubberduck.Refactorings.EncapsulateField
@@ -59,18 +58,10 @@ public class EncapsulateFieldCandidate : IEncapsulateFieldCandidate
5958
protected EncapsulationIdentifiers _fieldAndProperty;
6059
private string _rhsParameterIdentifierName;
6160

62-
//<<<<<<< HEAD
63-
public EncapsulateFieldCandidate(Declaration declaration, Func<string, string> parameterNameBuilder)
64-
//{
65-
//_target = declaration;
66-
//_parameterNameBuilder = parameterNameBuilder;
67-
//=======
68-
//public EncapsulateFieldCandidate(Declaration declaration, IValidateVBAIdentifiers identifierValidator)
61+
public EncapsulateFieldCandidate(Declaration declaration)
6962
{
7063
_target = declaration;
71-
//NameValidator = identifierValidator;
7264
_rhsParameterIdentifierName = Resources.Refactorings.Refactorings.CodeBuilder_DefaultPropertyRHSParam;
73-
//>>>>>>> rubberduck-vba/next
7465

7566
_fieldAndProperty = new EncapsulationIdentifiers(declaration.IdentifierName);
7667
IdentifierName = declaration.IdentifierName;
@@ -86,8 +77,7 @@ public EncapsulateFieldCandidate(Declaration declaration, Func<string, string> p
8677
ImplementSet = false;
8778
if (_target.IsEnumField() && _target.AsTypeDeclaration.HasPrivateAccessibility())
8879
{
89-
//5.3.1 The declared type of a function declaration
90-
//may not be a private enum name.
80+
//5.3.1 The declared type of a function declaration may not be a private enum.
9181
PropertyAsTypeName = Tokens.Long;
9282
}
9383
else if (_target.AsTypeName.Equals(Tokens.Variant)

Rubberduck.Refactorings/EncapsulateField/FieldCandidates/EncapsulateFieldCandidateFactory.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@ public IEncapsulateFieldCandidate Create(Declaration target)
2626
{
2727
if (target.IsUserDefinedType())
2828
{
29-
var udtField = new UserDefinedTypeCandidate(target, _codeBuilder.BuildPropertyRhsParameterName) as IUserDefinedTypeCandidate;
29+
var udtField = new UserDefinedTypeCandidate(target) as IUserDefinedTypeCandidate;
3030

3131
var udtMembers = _declarationFinderProvider.DeclarationFinder
3232
.UserDeclarations(DeclarationType.UserDefinedTypeMember)
3333
.Where(utm => udtField.Declaration.AsTypeDeclaration == utm.ParentDeclaration);
3434

3535
foreach (var udtMemberDeclaration in udtMembers)
3636
{
37-
var candidateUDTMember = new UserDefinedTypeMemberCandidate(Create(udtMemberDeclaration), udtField, _codeBuilder.BuildPropertyRhsParameterName) as IUserDefinedTypeMemberCandidate;
37+
var candidateUDTMember = new UserDefinedTypeMemberCandidate(Create(udtMemberDeclaration), udtField) as IUserDefinedTypeMemberCandidate;
3838

3939
udtField.AddMember(candidateUDTMember);
4040
}
@@ -50,11 +50,11 @@ public IEncapsulateFieldCandidate Create(Declaration target)
5050
}
5151
else if (target.IsArray)
5252
{
53-
var arrayCandidate = new ArrayCandidate(target, _codeBuilder.BuildPropertyRhsParameterName);
53+
var arrayCandidate = new ArrayCandidate(target);
5454
return arrayCandidate;
5555
}
5656

57-
return new EncapsulateFieldCandidate(target, _codeBuilder.BuildPropertyRhsParameterName);
57+
return new EncapsulateFieldCandidate(target);
5858
}
5959
}
6060
}

Rubberduck.Refactorings/EncapsulateField/FieldCandidates/UserDefinedTypeCandidate.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
using Rubberduck.Parsing.Grammar;
22
using Rubberduck.Parsing.Symbols;
33
using Rubberduck.Refactorings.Common;
4-
using System;
54
using System.Collections.Generic;
65

76
namespace Rubberduck.Refactorings.EncapsulateField
@@ -17,8 +16,8 @@ public interface IUserDefinedTypeCandidate : IEncapsulateFieldCandidate
1716

1817
public class UserDefinedTypeCandidate : EncapsulateFieldCandidate, IUserDefinedTypeCandidate
1918
{
20-
public UserDefinedTypeCandidate(Declaration declaration, Func<string,string> parameterNameBuilder)
21-
: base(declaration, parameterNameBuilder)
19+
public UserDefinedTypeCandidate(Declaration declaration)
20+
: base(declaration)
2221
{
2322
TypeDeclarationIsPrivate = declaration.HasPrivateAccessibility();
2423
}

0 commit comments

Comments
 (0)