Method rename and other minor changes

Author: BZngr

Rubberduck.CodeAnalysis/Inspections/Concrete/UnreachableCaseInspection/ParseTreeValueVisitor.cs

@@ -16,7 +16,7 @@ public interface IParseTreeValueVisitor : IParseTreeVisitor<IParseTreeVisitorRes
 
     public interface ITestParseTreeVisitor
     {
-        bool IsVBStringConstantToLiteral(string token, out string literalValue);
+        bool IsVBStringConstant(string token, out string literalValue);
         bool IsNonPrintingControlCharacter(string token);
         void InjectValuedDeclarationEvaluator(Func<Declaration, (bool, string, string)> func);
     }
@@ -336,7 +336,7 @@ private void GetContextValue(ParserRuleContext context, out string declaredTypeN
                     expressionValue = ExpressionValue;
                     declaredTypeName = TypeName;
 
-                    if (IsVBStringConstantToLiteral(expressionValue, out string constLiteral))
+                    if (IsVBStringConstant(expressionValue, out string constLiteral))
                     {
                         declaredTypeName = Tokens.String;
                         expressionValue = constLiteral;
@@ -450,20 +450,14 @@ private static bool IsBinaryOpEvaluationContext<T>(T context)
             return false;
         }
 
-        public bool IsVBStringConstantToLiteral(string candidate, out string literal)
-        {
-            return _vbStringConstants.TryGetValue(candidate, out literal);
-        }
+        public bool IsVBStringConstant(string candidate, out string literal)
+            => _vbStringConstants.TryGetValue(candidate, out literal);
 
         public bool IsNonPrintingControlCharacter(string controlChar)
-        {
-            return controlChar != null && _vbStringConstants.ContainsValue(controlChar);
-        }
+            => controlChar != null && _vbStringConstants.ContainsValue(controlChar);
 
         public void InjectValuedDeclarationEvaluator( Func<Declaration, (bool, string, string)> func)
-        {
-            ValuedDeclarationEvaluator = func;
-        }
+            => ValuedDeclarationEvaluator = func;
 
         private void LoadEnumMemberValues()
         {

RubberduckTests/Inspections/UnreachableCase/UnreachableCaseInspectionTests.cs

@@ -2455,7 +2455,7 @@ End Sub
         public void UnreachableCaseInspection_VbStringConstantToLiteral_AreEqual(string constToken, string expected)
         {
             var parseTreeValueVisitor = new ParseTreeValueVisitor(null, new List<VBAParser.EnumerationStmtContext>(), null) as ITestParseTreeVisitor;
-            if (parseTreeValueVisitor.IsVBStringConstantToLiteral(constToken, out string literalValue))
+            if (parseTreeValueVisitor.IsVBStringConstant(constToken, out string literalValue))
             {
                 Assert.AreEqual(expected, literalValue);
                 return;