added quotes around annotation value

retailcoder · retailcoder · commit 0a09d07af781 · 2019-08-23T00:44:22.000-04:00
diff --git a/Rubberduck.Parsing/Annotations/AttributeAnnotationProvider.cs b/Rubberduck.Parsing/Annotations/AttributeAnnotationProvider.cs
@@ -36,7 +36,7 @@ public class AttributeAnnotationProvider : IAttributeAnnotationProvider
                 // FIXME special cased bodge for ExcelHotKeyAnnotation to deal with the value transformation:
                 if (flexibleValueAttributeAnnotation == AnnotationType.ExcelHotKey)
                 {
-                    return (flexibleValueAttributeAnnotation, attributeValues.Select(keySpec => keySpec.Substring(1, 1)).ToList());
+                    return (flexibleValueAttributeAnnotation, attributeValues.Select(keySpec => '"' + keySpec.Substring(1, 1) + '"').ToList());
                 }
                 return (flexibleValueAttributeAnnotation, attributeValues);
             }
diff --git a/RubberduckTests/Annotations/AttributeAnnotationProviderTests.cs b/RubberduckTests/Annotations/AttributeAnnotationProviderTests.cs
@@ -57,7 +57,7 @@ public void ModuleAttributeAnnotationReturnsSpecializedAnnotationsWhereApplicabl
             AssertEqual(expectedValues, actualValues);
         }
 
-        [TestCase("VB_ProcData.VB_Invoke_Func", "\"A\n14\"", AnnotationType.ExcelHotKey, "A")]
+        [TestCase("VB_ProcData.VB_Invoke_Func", "\"A\n14\"", AnnotationType.ExcelHotKey, "\"A\"")]
         [TestCase("VB_Description", "\"SomeDescription\"", AnnotationType.Description, "\"SomeDescription\"")]
         [TestCase("VB_VarDescription", "\"SomeDescription\"", AnnotationType.VariableDescription, "\"SomeDescription\"")]
         [TestCase("VB_UserMemId", "0", AnnotationType.DefaultMember)]

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public class AttributeAnnotationProvider : IAttributeAnnotationProvider`
`36`	`36`	`// FIXME special cased bodge for ExcelHotKeyAnnotation to deal with the value transformation:`
`37`	`37`	`if (flexibleValueAttributeAnnotation == AnnotationType.ExcelHotKey)`
`38`	`38`	`{`
`39`		`- return (flexibleValueAttributeAnnotation, attributeValues.Select(keySpec => keySpec.Substring(1, 1)).ToList());`
	`39`	`+ return (flexibleValueAttributeAnnotation, attributeValues.Select(keySpec => '"' + keySpec.Substring(1, 1) + '"').ToList());`
`40`	`40`	`}`
`41`	`41`	`return (flexibleValueAttributeAnnotation, attributeValues);`
`42`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public void ModuleAttributeAnnotationReturnsSpecializedAnnotationsWhereApplicabl`
`57`	`57`	`AssertEqual(expectedValues, actualValues);`
`58`	`58`	`}`
`59`	`59`
`60`		`- [TestCase("VB_ProcData.VB_Invoke_Func", "\"A\n14\"", AnnotationType.ExcelHotKey, "A")]`
	`60`	`+ [TestCase("VB_ProcData.VB_Invoke_Func", "\"A\n14\"", AnnotationType.ExcelHotKey, "\"A\"")]`
`61`	`61`	`[TestCase("VB_Description", "\"SomeDescription\"", AnnotationType.Description, "\"SomeDescription\"")]`
`62`	`62`	`[TestCase("VB_VarDescription", "\"SomeDescription\"", AnnotationType.VariableDescription, "\"SomeDescription\"")]`
`63`	`63`	`[TestCase("VB_UserMemId", "0", AnnotationType.DefaultMember)]`