added xaml binding for min/max values, cleaned up SCP

Author: retailcoder

Rubberduck.Core/AutoComplete/Service/SelfClosingPair.cs

@@ -5,14 +5,6 @@ namespace Rubberduck.AutoComplete.Service
 {
     public class SelfClosingPair : IEquatable<SelfClosingPair>
     {
-        [Flags]
-        public enum MatchType
-        {
-            NoMatch = 0,
-            OpeningCharacterMatch = 1,
-            ClosingCharacterMatch = 2,
-        }
-
         public SelfClosingPair(char opening, char closing)
         {
             OpeningChar = opening;

Rubberduck.Core/Settings/AutoCompleteSettings.cs

@@ -1,8 +1,5 @@
-using Rubberduck.AutoComplete;
-using System;
-using System.Collections.Generic;
+using System;
 using System.Configuration;
-using System.Linq;
 using System.Xml.Serialization;
 
 namespace Rubberduck.Settings
@@ -27,6 +24,15 @@ public interface IAutoCompleteSettings
     [XmlType(AnonymousType = true)]
     public class AutoCompleteSettings : IAutoCompleteSettings, IEquatable<AutoCompleteSettings>
     {
+        /// <summary>
+        /// Less than that would be useless (wouldn't concat).
+        /// </summary>
+        public static readonly int ConcatMaxLinesMinValue = 2;
+        /// <summary>
+        /// /More than that would be illegal (wouldn't compile).
+        /// </summary>
+        public static readonly int ConcatMaxLinesMaxValue = 25;
+
         public static AutoCompleteSettings AllEnabled =>
             new AutoCompleteSettings
             {
@@ -58,7 +64,6 @@ public AutoCompleteSettings()
         public class SmartConcatSettings : IEquatable<SmartConcatSettings>
         {
             private int _maxLogicalLineLineCount;
-            private const int MaximumLines = 25; // more than that wouldn't compile
 
             [XmlAttribute]
             public bool IsEnabled { get; set; }
@@ -69,15 +74,15 @@ public int MaxLogicalLineLineCount
                 get => _maxLogicalLineLineCount;
                 set
                 {
-                    if (value > MaximumLines)
+                    if (value > ConcatMaxLinesMaxValue)
                     {
-                        value = MaximumLines;
+                        value = ConcatMaxLinesMaxValue;
                     }
-
-                    if (value < 5)
+                    else if (value < ConcatMaxLinesMinValue)
                     {
-                        value = 5; // completely arbitrary magical value. 
+                        value = ConcatMaxLinesMinValue;
                     }
+
                     _maxLogicalLineLineCount = value;
                 }
             }

Rubberduck.Core/UI/Settings/AutoCompleteSettings.xaml

@@ -112,7 +112,10 @@
                           Content="{Resx ResxName=Rubberduck.Resources.Settings.AutoCompletesPage, Key=ConcatVbNewLine}" />
 
                 <Label Margin="15,0,15,0" Content="{Resx ResxName=Rubberduck.Resources.Settings.AutoCompletesPage, Key=ConcatMaxLines}" />
-                <controls:NumberPicker Margin="15,0,15,0" NumValue="{Binding ConcatMaxLines}" />
+                <controls:NumberPicker Margin="15,0,15,0" 
+                                       NumValue="{Binding ConcatMaxLines}"
+                                       MinNumber="{Binding ConcatMaxLinesMinValue}"
+                                       MaxNumber="{Binding ConcatMaxLinesMaxValue}"/>
 
                 <Label Margin="10" 
                        Content="{Resx ResxName=Rubberduck.Resources.Settings.AutoCompletesPage, Key=BlockCompletion}"

Rubberduck.Core/UI/Settings/AutoCompleteSettingsViewModel.cs

@@ -123,6 +123,9 @@ public int ConcatMaxLines
             }
         }
 
+        public int ConcatMaxLinesMinValue => Rubberduck.Settings.AutoCompleteSettings.ConcatMaxLinesMinValue;
+        public int ConcatMaxLinesMaxValue => Rubberduck.Settings.AutoCompleteSettings.ConcatMaxLinesMaxValue;
+
         private bool _enableBlockCompletion;
 
         public bool EnableBlockCompletion