fixed/standardized inspection names, result descriptions and UI bottom panel; added ImplicitDefaultMemberAssignmentInspection

Author: retailcoder

RetailCoder.VBE/Inspections/EmptyStringLiteralInspection.cs

@@ -20,7 +20,7 @@ public EmptyStringLiteralInspection(RubberduckParserState state)
         }
 
         public override string Meta { get { return InspectionsUI.EmptyStringLiteralInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.EmptyStringLiteralInspection; } }
+        public override string Description { get { return InspectionsUI.EmptyStringLiteralInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.LanguageOpportunities; } }
 
         public IEnumerable<QualifiedContext<VBAParser.LiteralExpressionContext>> ParseTreeResults { get { return _parseTreeResults.OfType<QualifiedContext<VBAParser.LiteralExpressionContext>>(); } }

RetailCoder.VBE/Inspections/ImplicitActiveSheetReferenceInspection.cs

@@ -21,7 +21,7 @@ public ImplicitActiveSheetReferenceInspection(IVBE vbe, RubberduckParserState st
         }
 
         public override string Meta { get { return InspectionsUI.ImplicitActiveSheetReferenceInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.ImplicitActiveSheetReferenceInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.ImplicitActiveSheetReferenceInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
 
         private static readonly string[] Targets = 

RetailCoder.VBE/Inspections/ImplicitActiveWorkbookReferenceInspection.cs

@@ -21,7 +21,7 @@ public ImplicitActiveWorkbookReferenceInspection(IVBE vbe, RubberduckParserState
         }
 
         public override string Meta { get { return InspectionsUI.ImplicitActiveWorkbookReferenceInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.ImplicitActiveWorkbookReferenceInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.ImplicitActiveWorkbookReferenceInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
 
         private static readonly string[] Targets =

RetailCoder.VBE/Inspections/ImplicitDefaultMemberAssignmentInspection.cs

@@ -0,0 +1,41 @@
+using System.Collections.Generic;
+using System.Linq;
+using Rubberduck.Inspections.Abstract;
+using Rubberduck.Inspections.Resources;
+using Rubberduck.Inspections.Results;
+using Rubberduck.Parsing.Grammar;
+using Rubberduck.Parsing.Symbols;
+using Rubberduck.Parsing.VBA;
+
+namespace Rubberduck.Inspections
+{
+    public sealed class ImplicitDefaultMemberAssignmentInspection : InspectionBase
+    {
+        public ImplicitDefaultMemberAssignmentInspection(RubberduckParserState state)
+            : base(state, CodeInspectionSeverity.Suggestion)
+        {
+        }
+
+        public override IEnumerable<InspectionResultBase> GetInspectionResults()
+        {
+            var interestingDeclarations =
+                State.AllDeclarations.Where(item =>
+                    item.AsTypeDeclaration != null
+                    && ClassModuleDeclaration.HasDefaultMember(item.AsTypeDeclaration));
+
+            var interestingReferences = interestingDeclarations
+                .SelectMany(declaration => declaration.References)
+                .Where(reference =>
+                {
+                    var letStmtContext = ParserRuleContextHelper.GetParent<VBAParser.LetStmtContext>(reference.Context);
+                    return reference.IsAssignment && letStmtContext != null && letStmtContext.LET() == null;
+                });
+
+            return interestingReferences.Select(reference => new ImplicitDefaultMemberAssignmentInspectionResult(this, reference));
+        }
+
+        public override string Meta { get { return InspectionsUI.ImplicitDefaultMemberAssignmentInspectionMeta; } }
+        public override string Description { get { return InspectionsUI.ImplicitDefaultMemberAssignmentInspectionName; } }
+        public override CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
+    }
+}

RetailCoder.VBE/Inspections/MissingAnnotationArgumentInspection.cs

@@ -20,7 +20,7 @@ public MissingAnnotationArgumentInspection(RubberduckParserState state)
         }
 
         public override string Meta { get { return InspectionsUI.MissingAnnotationArgumentInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.MissingAnnotationArgumentInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.MissingAnnotationArgumentInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.CodeQualityIssues; } }
         public IEnumerable<QualifiedContext<VBAParser.AnnotationContext>> ParseTreeResults { get { return _parseTreeResults.OfType<QualifiedContext<VBAParser.AnnotationContext>>(); } }
 

RetailCoder.VBE/Inspections/MultipleDeclarationsInspection.cs

@@ -18,7 +18,7 @@ public MultipleDeclarationsInspection(RubberduckParserState state)
         }
 
         public override string Meta { get { return InspectionsUI.MultipleDeclarationsInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.MultipleDeclarationsInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.MultipleDeclarationsInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
 
         public override IEnumerable<InspectionResultBase> GetInspectionResults()

RetailCoder.VBE/Inspections/MultipleFolderAnnotationsInspection.cs

@@ -17,7 +17,7 @@ public MultipleFolderAnnotationsInspection(RubberduckParserState state)
         }
 
         public override string Meta { get { return InspectionsUI.MultipleFolderAnnotationsInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.MultipleFolderAnnotationsInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.MultipleFolderAnnotationsInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.MaintainabilityAndReadabilityIssues; } }
 
         public override IEnumerable<InspectionResultBase> GetInspectionResults()

RetailCoder.VBE/Inspections/ObjectVariableNotSetInspection.cs

@@ -17,7 +17,7 @@ public ObjectVariableNotSetInspection(RubberduckParserState state)
         }
 
         public override string Meta { get { return InspectionsUI.ObjectVariableNotSetInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.ObjectVariableNotSetInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.ObjectVariableNotSetInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.CodeQualityIssues; } }
 
         private static readonly IReadOnlyList<string> ValueTypes = new[]

RetailCoder.VBE/Inspections/ObsoleteCallStatementInspection.cs

@@ -19,7 +19,7 @@ public ObsoleteCallStatementInspection(RubberduckParserState state)
         }
 
         public override string Meta { get { return InspectionsUI.ObsoleteCallStatementInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.ObsoleteCallStatementInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.ObsoleteCallStatementInspectionName; } }
         public override CodeInspectionType InspectionType { get { return CodeInspectionType.LanguageOpportunities; } }
 
         public IEnumerable<QualifiedContext<VBAParser.CallStmtContext>> ParseTreeResults { get { return _parseTreeResults.OfType<QualifiedContext<VBAParser.CallStmtContext>>(); } }

RetailCoder.VBE/Inspections/ObsoleteCommentSyntaxInspection.cs

@@ -19,7 +19,7 @@ public ObsoleteCommentSyntaxInspection(RubberduckParserState state)
         }
 
         public override string Meta { get { return InspectionsUI.ObsoleteCommentSyntaxInspectionMeta; } }
-        public override string Description { get { return InspectionsUI.ObsoleteCommentSyntaxInspectionResultFormat; } }
+        public override string Description { get { return InspectionsUI.ObsoleteCommentSyntaxInspectionName; } }
         public override CodeInspectionType InspectionType { get {return CodeInspectionType.LanguageOpportunities; } }
 
         public override IEnumerable<InspectionResultBase> GetInspectionResults()