Address review comments.

Author: comintern

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerComponentViewModel.cs

@@ -6,6 +6,7 @@
 using Rubberduck.VBEditor.SafeComWrappers;
 using Rubberduck.Resources.CodeExplorer;
 using Rubberduck.VBEditor.SafeComWrappers.Abstract;
+using System;
 
 namespace Rubberduck.Navigation.CodeExplorer
 {
@@ -113,9 +114,9 @@ private void SetName()
                         break;
                 }
             }
-            catch
+            catch (Exception ex)
             {
-                //Ignored;
+                Logger.Trace(ex);
             }
 
             OnNameChanged();

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerCustomFolderViewModel.cs

@@ -49,7 +49,7 @@ public CodeExplorerCustomFolderViewModel(
         public override bool IsErrorState
         {
             get => false;
-            set { }
+            set { /* Folders can never be in an error state. */ }
         }
 
         public override Comparer<ICodeExplorerNode> SortComparer => CodeExplorerItemComparer.Name;

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerItemViewModel.cs

@@ -41,7 +41,7 @@ public virtual void Synchronize(List<Declaration> updated)
                 return;
             }
 
-            var matching = updated.FirstOrDefault(decl => Declaration.QualifiedName.Equals(decl?.QualifiedName));
+            var matching = updated.FirstOrDefault(decl => Declaration.DeclarationType == decl?.DeclarationType && Declaration.QualifiedName.Equals(decl?.QualifiedName));
 
             if (matching is null)
             {

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerItemViewModelBase.cs

@@ -5,6 +5,7 @@
 using System.Globalization;
 using System.Linq;
 using System.Windows;
+using NLog;
 using Rubberduck.Parsing;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Resources;
@@ -15,6 +16,8 @@ namespace Rubberduck.Navigation.CodeExplorer
 {
     public abstract class CodeExplorerItemViewModelBase : ViewModelBase, ICodeExplorerNode
     {
+        protected static readonly Logger Logger = LogManager.GetCurrentClassLogger();
+
         protected CodeExplorerItemViewModelBase(ICodeExplorerNode parent, Declaration declaration)
         {
             Parent = parent;

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerReferenceViewModel.cs

@@ -31,7 +31,7 @@ public CodeExplorerReferenceViewModel(ICodeExplorerNode parent, ReferenceModel r
         public override bool IsErrorState
         {
             get => false;
-            set { }
+            set { /* References can never be in an error state (in this context). */ }
         }
 
         public override string ToolTip => Reference?.Description ?? string.Empty;

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerViewModel.cs

@@ -68,8 +68,8 @@ public CodeExplorerViewModel(
             _vbe = vbe;
             _templateProvider = templateProvider;
 
-            CollapseAllSubnodesCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteCollapseNodes);
-            ExpandAllSubnodesCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteExpandNodes);
+            CollapseAllSubnodesCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteCollapseNodes, EvaluateCanSwitchNodeState);
+            ExpandAllSubnodesCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteExpandNodes, EvaluateCanSwitchNodeState);
             ClearSearchCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteClearSearchCommand);
             if (_externalRemoveCommand != null)
             {
@@ -308,6 +308,11 @@ private void ExecuteClearSearchCommand(object parameter)
             }
         }
 
+        private bool EvaluateCanSwitchNodeState(object parameter)
+        {
+            return SelectedItem?.Children?.Any() ?? false;
+        }
+
         private void ExecuteCollapseNodes(object parameter)
         {
             if (!(parameter is ICodeExplorerNode node))

Rubberduck.Core/UI/CodeExplorer/Commands/AddMDIFormCommand.cs

@@ -33,17 +33,17 @@ protected override bool EvaluateCanExecute(object parameter)
 
             if (project != null || Vbe.ProjectsCount != 1)
             {
-                return EvaluateCanExecuteCore(project, node);
+                return EvaluateCanExecuteForProject(project, node);
             }
 
             using (var vbProjects = Vbe.VBProjects)
             using (project = vbProjects[1])
             {
-                return EvaluateCanExecuteCore(project, node);
+                return EvaluateCanExecuteForProject(project, node);
             }
         }
 
-        private bool EvaluateCanExecuteCore(IVBProject project, CodeExplorerItemViewModel itemViewModel)
+        private bool EvaluateCanExecuteForProject(IVBProject project, CodeExplorerItemViewModel itemViewModel)
         {
             if (project == null)
             {

Rubberduck.Core/UI/Command/SyncCodeExplorerCommand.cs

@@ -48,7 +48,6 @@ protected override bool EvaluateCanExecute(object parameter)
         {
             if (_state.Status != ParserState.Ready || 
                 _explorer.IsBusy || 
-                //_explorer.TreeViewVisibility != Visibility.Visible ||
                 FindTargetNode() == null)
             {
                 return false;