Fixed structure scope, parameter scope, simplify name creation in ctors. Fix Len{B} Declaration selection.

Author: comintern

RetailCoder.VBE/Inspections/UnassignedVariableUsageInspection.cs

@@ -30,8 +30,9 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
                 && !declaration.IsSelfAssigned
                 && !declaration.References.Any(reference => reference.IsAssignment));
 
-            var lenFunction = BuiltInDeclarations.SingleOrDefault(s => s.Scope == "VBE7.DLL;VBA.Strings.Len");
-            var lenbFunction = BuiltInDeclarations.SingleOrDefault(s => s.Scope == "VBE7.DLL;VBA.Strings.LenB");
+            //The parameter scoping was apparently incorrect before - need to filter for the actual function.
+            var lenFunction = BuiltInDeclarations.SingleOrDefault(s => s.DeclarationType == DeclarationType.Function && s.Scope.Equals("VBE7.DLL;VBA.Strings.Len"));
+            var lenbFunction = BuiltInDeclarations.SingleOrDefault(s => s.DeclarationType == DeclarationType.Function && s.Scope.Equals("VBE7.DLL;VBA.Strings.Len"));
 
             return from issue in declarations 
                    where issue.References.Any()

Rubberduck.Parsing/Symbols/ClassModuleDeclaration.cs

@@ -54,7 +54,7 @@ public ClassModuleDeclaration(
         public ClassModuleDeclaration(ComCoClass coClass, Declaration parent, QualifiedModuleName module,
             Attributes attributes)
             : base(
-                new QualifiedMemberName(module, coClass.Name),
+                module.QualifyMemberName(coClass.Name),
                 parent,
                 parent,
                 coClass.Name,
@@ -82,7 +82,7 @@ public ClassModuleDeclaration(ComCoClass coClass, Declaration parent, QualifiedM
         public ClassModuleDeclaration(ComInterface intrface, Declaration parent, QualifiedModuleName module,
             Attributes attributes)
             : this(
-                new QualifiedMemberName(module, intrface.Name),
+                module.QualifyMemberName(intrface.Name),
                 parent,
                 intrface.Name,
                 true,

Rubberduck.Parsing/Symbols/Declaration.cs

@@ -165,7 +165,7 @@ public Declaration(
         }
 
         public Declaration(ComEnumeration enumeration, Declaration parent, QualifiedModuleName module) : this(
-                new QualifiedMemberName(module, enumeration.Name),
+                module.QualifyMemberName(enumeration.Name),
                 parent,
                 parent,
                 enumeration.Name,
@@ -183,7 +183,7 @@ public Declaration(ComEnumeration enumeration, Declaration parent, QualifiedModu
                 new Attributes()) { }
 
         public Declaration(ComEnumerationMember member, Declaration parent, QualifiedModuleName module) : this(
-                new QualifiedMemberName(module, member.Name),
+                module.QualifyMemberName(member.Name),
                 parent,
                 parent,
                 parent.IdentifierName,
@@ -199,7 +199,7 @@ public Declaration(ComEnumerationMember member, Declaration parent, QualifiedMod
 
         public Declaration(ComField field, Declaration parent, QualifiedModuleName module)
             : this(
-                new QualifiedMemberName(module, field.Name),
+                module.QualifyMemberName(field.Name),
                 parent,
                 parent,
                 field.Name,

Rubberduck.Parsing/Symbols/FunctionDeclaration.cs

@@ -50,7 +50,7 @@ public FunctionDeclaration(
 
         public FunctionDeclaration(ComMember member, Declaration parent, QualifiedModuleName module,
             Attributes attributes) : this(
-                new QualifiedMemberName(module, member.Name),
+                module.QualifyMemberName(member.Name),
                 parent,
                 parent,
                 member.ReturnType.TypeName,

Rubberduck.Parsing/Symbols/ParameterDeclaration.cs

@@ -79,7 +79,7 @@ public ParameterDeclaration(QualifiedMemberName qualifiedName,
 
         public ParameterDeclaration(ComParameter parameter, Declaration parent, QualifiedModuleName module)
             : this(
-                new QualifiedMemberName(module, parameter.Name),
+                module.QualifyMemberName(parameter.Name),
                 parent,
                 parameter.TypeName,
                 null,

Rubberduck.Parsing/Symbols/ProceduralModuleDeclaration.cs

@@ -36,7 +36,7 @@ public ProceduralModuleDeclaration(
         public ProceduralModuleDeclaration(ComModule statics, Declaration parent, QualifiedModuleName module,
             Attributes attributes)
             : this(
-                new QualifiedMemberName(module, statics.Name),
+                module.QualifyMemberName(statics.Name),
                 parent,
                 statics.Name,
                 true,
@@ -49,7 +49,7 @@ public ProceduralModuleDeclaration(ComModule statics, Declaration parent, Qualif
         //This is the pseudo-module ctor for COM enumerations.
         public ProceduralModuleDeclaration(ComEnumeration enumeration, Declaration parent, QualifiedModuleName module)
             : this(
-                new QualifiedMemberName(module, string.Format("_{0}", enumeration.Name)),
+                module.QualifyMemberName(string.Format("_{0}", enumeration.Name)),
                 parent,
                 string.Format("_{0}", enumeration.Name),
                 true,
@@ -59,7 +59,7 @@ public ProceduralModuleDeclaration(ComEnumeration enumeration, Declaration paren
         //This is the pseudo-module ctor for anything else from COM with fields instead of members.
         public ProceduralModuleDeclaration(string pseudo, Declaration parent, QualifiedModuleName module)
             : this(
-                new QualifiedMemberName(module, pseudo),
+                module.QualifyMemberName(pseudo),
                 parent,
                 pseudo,
                 true,

Rubberduck.Parsing/Symbols/ProjectDeclaration.cs

@@ -33,7 +33,7 @@ public ProjectDeclaration(
         }
 
         public ProjectDeclaration(ComProject project, QualifiedModuleName module)
-            : this(new QualifiedMemberName(module, project.Name), project.Name, true)
+            : this(module.QualifyMemberName(project.Name), project.Name, true)
         {
             MajorVersion = project.MajorVersion;
             MinorVersion = project.MinorVersion;

Rubberduck.Parsing/Symbols/PropertyGetDeclaration.cs

@@ -51,7 +51,7 @@ public PropertyGetDeclaration(
         public PropertyGetDeclaration(ComMember member, Declaration parent, QualifiedModuleName module,
             Attributes attributes)
             : this(
-                new QualifiedMemberName(module, member.Name),
+                module.QualifyMemberName(member.Name),
                 parent,
                 parent,
                 member.ReturnType.TypeName,

Rubberduck.Parsing/Symbols/PropertyLetDeclaration.cs

@@ -47,7 +47,7 @@ public PropertyLetDeclaration(
         public PropertyLetDeclaration(ComMember member, Declaration parent, QualifiedModuleName module,
             Attributes attributes)
             : this(
-                new QualifiedMemberName(module, member.Name),
+                module.QualifyMemberName(member.Name),
                 parent,
                 parent,
                 string.Empty, //TODO:  Need to get the types for these.
@@ -61,7 +61,7 @@ public PropertyLetDeclaration(ComMember member, Declaration parent, QualifiedMod
             _parameters =
                 member.Parameters.Select(decl => new ParameterDeclaration(decl, this, module))
                     .Cast<Declaration>()
-                    .ToList();  
+                    .ToList(); 
         }
 
         public IEnumerable<Declaration> Parameters

Rubberduck.Parsing/Symbols/PropertySetDeclaration.cs

@@ -46,7 +46,7 @@ public PropertySetDeclaration(
 
         public PropertySetDeclaration(ComMember member, Declaration parent, QualifiedModuleName module,
             Attributes attributes) : this(
-                new QualifiedMemberName(module, member.Name),
+                module.QualifyMemberName(member.Name),
                 parent,
                 parent,
                 string.Empty, //TODO:  Need to get the types for these.