Skip to content

Commit 02982ea

Browse files
authored
Merge pull request #3338 from shadowofsilicon/InspectionsExplorer
Performance improvement to Inspections Explorer
2 parents 4a0c3b6 + e935bdb commit 02982ea

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

RetailCoder.VBE/UI/Inspections/InspectionResultsControl.xaml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@
461461
</Style>
462462
</UserControl.Resources>
463463

464-
<Grid>
464+
<Grid UseLayoutRounding="True">
465465
<Grid.RowDefinitions>
466466
<RowDefinition Height="30"/>
467467
<RowDefinition Height="*" MinHeight="64" />
@@ -540,8 +540,9 @@
540540
<controls:GroupingGrid Grid.Row="1"
541541
ShowGroupingItemCount="True"
542542
SelectedItem="{Binding SelectedItem}"
543-
ItemsSource="{Binding Source={StaticResource ResultsByInspectionType}}"
544-
Visibility="{Binding IsChecked, ElementName=GroupByInspectionType, Converter={StaticResource BoolToVisibility}}">
543+
ItemsSource="{Binding Source={StaticResource ResultsByInspectionType}, IsAsync=True}"
544+
Visibility="{Binding IsChecked, ElementName=GroupByInspectionType, Converter={StaticResource BoolToVisibility}}"
545+
VirtualizingPanel.IsVirtualizingWhenGrouping="True">
545546
<DataGrid.Columns>
546547
<DataGridTemplateColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=CodeInspectionResults_Type}" SortDirection="Descending">
547548
<DataGridTemplateColumn.CellTemplate>
@@ -558,8 +559,9 @@
558559
<controls:GroupingGrid Grid.Row="1"
559560
ShowGroupingItemCount="True"
560561
SelectedItem="{Binding SelectedItem}"
561-
ItemsSource="{Binding Source={StaticResource ResultsByModule}}"
562-
Visibility="{Binding IsChecked, ElementName=GroupByLocation, Converter={StaticResource BoolToVisibility}}">
562+
ItemsSource="{Binding Source={StaticResource ResultsByModule}, IsAsync=True}"
563+
Visibility="{Binding IsChecked, ElementName=GroupByLocation, Converter={StaticResource BoolToVisibility}}"
564+
VirtualizingPanel.IsVirtualizingWhenGrouping="True">
563565
<DataGrid.Columns>
564566
<DataGridTemplateColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=CodeInspectionResults_Type}">
565567
<DataGridTemplateColumn.CellTemplate>

RetailCoder.VBE/UI/Inspections/InspectionResultsViewModel.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,9 +301,11 @@ private async void RefreshInspections()
301301
.ToList();
302302
}
303303

304+
Results = new ObservableCollection<IInspectionResult>(results);
305+
304306
UiDispatcher.Invoke(() =>
305307
{
306-
Results = new ObservableCollection<IInspectionResult>(results);
308+
//Results = new ObservableCollection<IInspectionResult>(results);
307309

308310
IsBusy = false;
309311
IsRefreshing = false;

0 commit comments

Comments
 (0)