Skip to content

Commit 01cdb4d

Browse files
committed
Fix description in ObsoleteGlobalInspection. Closes #2685
1 parent a3cd649 commit 01cdb4d

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

RetailCoder.VBE/Inspections/ObsoleteGlobalInspection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
2525
{
2626
var issues = from item in UserDeclarations
2727
where item.Accessibility == Accessibility.Global && item.Context != null
28-
select new ObsoleteGlobalInspectionResult(this, new QualifiedContext<ParserRuleContext>(item.QualifiedName.QualifiedModuleName, item.Context));
28+
select new ObsoleteGlobalInspectionResult(this, new QualifiedContext<ParserRuleContext>(item.QualifiedName.QualifiedModuleName, item.Context), item);
2929

3030
return issues;
3131
}

RetailCoder.VBE/Inspections/Results/ObsoleteGlobalInspectionResult.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,16 @@
55
using Rubberduck.Inspections.QuickFixes;
66
using Rubberduck.Inspections.Resources;
77
using Rubberduck.Parsing;
8+
using Rubberduck.Parsing.Symbols;
89

910
namespace Rubberduck.Inspections.Results
1011
{
1112
public class ObsoleteGlobalInspectionResult : InspectionResultBase
1213
{
1314
private IEnumerable<QuickFixBase> _quickFixes;
1415

15-
public ObsoleteGlobalInspectionResult(IInspection inspection, QualifiedContext<ParserRuleContext> context)
16-
: base(inspection, context.ModuleName, context.Context)
16+
public ObsoleteGlobalInspectionResult(IInspection inspection, QualifiedContext<ParserRuleContext> context, Declaration target)
17+
: base(inspection, context.ModuleName, context.Context, target)
1718
{ }
1819

1920
public override IEnumerable<QuickFixBase> QuickFixes

Rubberduck.VBEEditor/SafeComWrappers/VBA/VBProjects.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ private static void AttachEvents()
130130

131131
private static void DetatchEvents()
132132
{
133-
if (!_eventsAttached)
133+
if (!_eventsAttached && _projects != null)
134134
{
135135
ComEventsHelper.Remove(_projects, VBProjectsEventsGuid, (int)ProjectEventDispId.ItemAdded, _projectAdded);
136136
ComEventsHelper.Remove(_projects, VBProjectsEventsGuid, (int)ProjectEventDispId.ItemRemoved, _projectRemoved);

0 commit comments

Comments
 (0)