Skip to content

Update jQuery-UI to 1.14.1 #4175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hedsnz opened this issue Jan 8, 2025 · 0 comments · May be fixed by #4205
Open

Update jQuery-UI to 1.14.1 #4175

hedsnz opened this issue Jan 8, 2025 · 0 comments · May be fixed by #4205

Comments

@hedsnz
Copy link
Contributor

hedsnz commented Jan 8, 2025

The version of jQuery UI bundled in https://github.com/rstudio/shiny/tree/main/inst/www/shared/jqueryui is 1.13.2.

According to Sonatype, this version is vulnerable to prototype pollution (SONATYPE-2024-011918):

The $.widget() function in widget.js does not properly check if the name parameter contains a risky JavaScript accessor such as proto or constructor when creating a new widget. An attacker can exploit this vulnerability by providing a crafted name to override the original JavaScript prototype and therefore values of objects used by the application. This may result in arbitrary code execution, data corruption, or application crashes.

This was fixed in jQuery UI 1.14.1: https://jqueryui.com/changelog/1.14.1/#widget-factory.

To be clear, a) I have on idea what shiny uses jQuery UI for, and b) I suspect the probablility that this is exploitable via shiny to be very low. However, it's probably good to keep these dependencies up-to-date anyway.

I authored the PR a couple of years ago that updated jQuery-UI at the time to 1.13.2; I'm happy to do this again if that would be helpful?

There's an equivalent issue over at py-shiny, posit-dev/py-shiny#1786.

Thanks.

hedsnz added a commit to hedsnz/shiny that referenced this issue Apr 10, 2025
@hedsnz hedsnz linked a pull request Apr 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant