Skip to content

Showcase mode won't display files with spaces in the name #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cwthom opened this issue Jan 21, 2018 · 2 comments · May be fixed by #2593
Open

Showcase mode won't display files with spaces in the name #1926

cwthom opened this issue Jan 21, 2018 · 2 comments · May be fixed by #2593
Assignees
@cpsievert
Labels
Difficulty: Novice Effort: Low Feature: Showcase Mode Related to or caused by showcase mode Type: Bug 🐛

Comments

@cwthom
Copy link

cwthom commented Jan 21, 2018

Hi there,

Found a little bug with shiny showcase mode - the code tabpanel won't display R scripts with spaces in the name. I've published a minimal example here: https://cwthom94.shinyapps.io/showcase-mode-issue/

Repo with code here: https://github.com/cwthom/shiny-showcase-issue

Possibly this isn't a bug but I couldn't find it documented anywhere so here you go :)

Huge thanks for shiny!
Chris
@alandipert alandipert added the Feature: Showcase Mode Related to or caused by showcase mode label May 8, 2019
@cpsievert
Copy link
Collaborator

Looks like these links no longer exist, are you still experiencing the same issue?

@cwthom
Copy link
Author

cwthom commented Sep 4, 2019

Hi @cpsievert Thanks for reviewing this. I've revived the shinyapps.io link - still seems to be the case (although that will be with very old package versions). I guess the issue is really that it's creating a HTML id with spaces in from the file name? Looks like shiny:::tabContentHelper and shiny:::navTabsHelper deal with dots in filenames but not spaces I think.

Possible solution would be to also gsub whitespace for underscores?

@cpsievert cpsievert self-assigned this Sep 9, 2019
cpsievert added a commit that referenced this issue Sep 10, 2019
@cpsievert
Replace spaces with underscores when mapping filenames to ids in the …
26dd456 
…showcase, closes #1926
@cpsievert cpsievert linked a pull request Sep 10, 2019 that will close this issue
Open
cpsievert added a commit that referenced this issue Sep 11, 2019
@cpsievert
Replace spaces with underscores when mapping filenames to ids in the …
e5dcd5e 
…showcase, closes #1926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpsievert cpsievert

Labels
Difficulty: Novice Effort: Low Feature: Showcase Mode Related to or caused by showcase mode Type: Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Showcase filenames rstudio/shiny
3 participants
@alandipert @cpsievert @cwthom